-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider and lookup typing #795
Provider and lookup typing #795
Conversation
FlorianBracq
commented
Aug 12, 2024
- Add more typing to msticpy/context files
- Replace outdated List/Union/Tuple/Dict/Set/Optional
- Add types in function definition
- Replace namedtuple and attr classes with dataclasses
- Exploding (some) kwargs to use explicit parameters
- Replace print with logging
- Remove redundant disabled pylint messages
- Set error messages in dedicated variables
- Forcing keyword-only arguments for boolean parameters
- Replacing some hard-coded values
- check httpx return code with property "is_success" instead of comparing to 200
…pdate-tiproviders-contextproviders
…ider-and-driver-typing
…rovider-and-driver-typing
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm exhausted looking at that - and I mostly just skimmed through. :-)
What an amazing amount of work!
I left a few comments - mostly about help/output that should be user-visible.
Also, did you use some kind of tool to do all of the annotation updates? |
# Conflicts: # msticpy/context/ip_utils.py
I'm mostly using ruff for it. It's not perfect, but it provides quite some good guidance. It's a pain to write and review (sorry for that ;)), but it does help making the code clearer and prevents some mistakes, so I would say it's worth it! |
Also some minor spacing/formatting things
…anBracq/msticpy into pr/FlorianBracq/795