Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: UnprotectUefiImageMu Does Not Clear Attributes #1014

Closed
1 task done
os-d opened this issue Jun 28, 2024 · 2 comments
Closed
1 task done

[Bug]: UnprotectUefiImageMu Does Not Clear Attributes #1014

os-d opened this issue Jun 28, 2024 · 2 comments
Assignees
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@os-d
Copy link
Contributor

os-d commented Jun 28, 2024

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

When unloading an image, UnprotectUefiImageMu calls into SetUefiMemoryAttributes with 0 for attributes. However that function gets the current attributes from the memory descriptor and ors those with the supplied attributes, which means the attributes can never be cleared. It also uses the ImageRecord->ImageSize as the range to clear, but that needs to be page aligned, as is done when the image is protected.

Expected Behavior

When unprotecting an image, the attributes should be cleared on a page aligned size.

Steps To Reproduce

Unprotect an image

Build Environment

- OS(s):
- Tool Chain(s):
- Targets Impacted:
All

Version Information

top of tree

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@os-d os-d added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Jun 28, 2024
@os-d os-d self-assigned this Jun 28, 2024
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Jun 28, 2024
Copy link

This issue has been automatically marked as stale because it has not had activity in 45 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the state:stale Has not been updated in a long time label Aug 23, 2024
Copy link

This issue has been automatically been closed because it did not have any activity in 45 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps state:stale Has not been updated in a long time type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Development

No branches or pull requests

1 participant