BaseTools/OverrideValidation: Sort files prior to hashing. #1145
+616
−245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
language:python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1145 +/- ##
===========================================
Coverage 1.59% 1.59%
===========================================
Files 1448 1448
Lines 362501 362501
Branches 5632 5632
===========================================
+ Hits 5775 5776 +1
+ Misses 356619 356618 -1
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Javagedes
reviewed
Sep 19, 2024
apop5
force-pushed
the
personal/apop5/updateoverridevalidatointosort
branch
3 times, most recently
from
1e941d2
to
fb8e099
Compare
apop5
force-pushed
the
personal/apop5/updateoverridevalidatointosort
branch
from
fb8e099
to
f77c86c
Compare
apop5
force-pushed
the
personal/apop5/updateoverridevalidatointosort
branch
from
03a7327
to
f77c86c
Compare
apop5
changed the title
Flickdm
reviewed
Oct 18, 2024
Flickdm
approved these changes
Oct 18, 2024
Javagedes
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Override validation allows hashing a directory through the -t parameter.
When generating an override validation hash for a directory, it was found that the order of the files can be different when running under linux vs under windows.
To address this discrepancy, a new module hash has been crated ModuleHash2Cal, which sorts the files prior to hashing.
Since existing projects use hashes based on ModuleHashCal, when performing override validation checking, check against the original ModuleHashCal and the ModuleHash2Cal prior to generating an override validation failure.
Generating a new hash value will only use the ModuleHash2Cal.
How This Was Tested
Tested changes on a project using existing project (to ensure backward compatibility)
Tested changes on the project under linux that was failing
Tested latest modifications on mu_feature_mm_supv to ensure no regression.
Integration Instructions
N/A