-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQUASH ON REBASE] Move inline comments to separate lines for tools_def #1190
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1190 +/- ##
===========================================
Coverage 1.59% 1.59%
===========================================
Files 1448 1448
Lines 362501 362501
Branches 5632 5632
===========================================
Hits 5776 5776
Misses 356618 356618
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark this as [SQUASH ON REBASE]?
I think so. What is the plan for catching this in the future? The PR description mentions updating the parser. If that's what is going to be done is that tracked somewhere? |
noup :) i was expecting someone to pick up that work. but i will create an issue before merging this. |
Created #1193 to track the potential parser change. |
Description
The existing change somehow will make the PP_FLAGS have
# MU_CHANGE
embedded, causing the build to fail:"PP_FLAGS" : -E -x assembler-with-cpp -include AutoGen.h # MU_CHANGE -I
This change removed applicable inline comments. But the real change should probably come from the parser.
How This Was Tested
This change was tested on the failing system and this fixed it.
Integration Instructions
N/A