[CHERRY-PICK] Added missing fix for ProductDataFormatter missed from 202311 (#1195) #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oft#1195) ## Description A fix for the ProductDataFormatter script was missed during the transition from 202311 to 202405. This just adds it back. For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? ## How This Was Tested Tested on physical hardware. Product Data is correctly being found. ## Integration Instructions N/A
kenlautner
changed the title
github-actions
bot
added
language:python
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202405 #1196 +/- ##
===============================================
Coverage 1.59% 1.59%
===============================================
Files 1448 1448
Lines 362502 362502
Branches 5632 5632
===============================================
Hits 5776 5776
Misses 356619 356619
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
approved these changes
Oct 25, 2024
|
This needs to go into dev as well, correct? |
This went into DEV already. I cherry-picked it over for this PR. |
makubacki
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A fix for the ProductDataFormatter script was missed during the transition from 202311 to 202405. This just adds it back.
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Tested on physical hardware. Product Data is correctly being found.
Integration Instructions
N/A