Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ORT Performance threading docs #16995

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

ivberg
Copy link
Contributor

@ivberg ivberg commented Aug 3, 2023

Description

Update ORT Performance threading docs. Clearer defaults, clearer explanation of INTRA thread behavior. Document spinning. Provide links to APIs

Motivation and Context

After discussion with ORT Performance team and in-depth testing of these settings. It was determined that docs were not clear, misleading at times, or needed missing info.

Update ORT Performance threading docs. Clearer defaults, clearer explanation of INTRA thread behavior. Document spinning. Provide links to APIs
@ivberg
Copy link
Contributor Author

ivberg commented Aug 4, 2023

For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose

Copy link
Contributor

@pranavsharma pranavsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this.

Copy link
Contributor Author

@ivberg ivberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fixes for PR review 1

@ivberg
Copy link
Contributor Author

ivberg commented Aug 28, 2023

@ivberg
Copy link
Contributor Author

ivberg commented Aug 29, 2023

For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose

@pranavsharma How should we handle this? Can you force merge the PR OR should we move this OR do you have a better working URL?

@ivberg
Copy link
Contributor Author

ivberg commented Sep 7, 2023

For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose

@pranavsharma How should we handle this? Can you force merge the PR OR should we move this OR do you have a better working URL?

Gentle ping @pranavsharma

For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose

@pranavsharma How should we handle this? Can you force merge the PR OR should we move this OR do you have a better working URL?

Gentle ping @pranavsharma

@hariharans29
Copy link
Member

For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose

@pranavsharma How should we handle this? Can you force merge the PR OR should we move this OR do you have a better working URL?

Gentle ping @pranavsharma

For the checklinks failure that is not related to this PR. Also the URL seems to be valid that is claims to have hit a 404 - https://github.com/microsoft/onnx-converters-private/issues/new/choose

@pranavsharma How should we handle this? Can you force merge the PR OR should we move this OR do you have a better working URL?

Gentle ping @pranavsharma

Hi @natke - Can this PR be merged ? Also, I don't see a 404 for this URL (https://github.com/microsoft/onnx-converters-private/issues/new/choose) anymore, I guess that link is up and running now ?

@natke natke self-requested a review September 25, 2023 21:35
@natke natke merged commit 7017289 into microsoft:gh-pages Sep 25, 2023
2 of 3 checks passed
@natke
Copy link
Contributor

natke commented Sep 25, 2023

Thank you @ivberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants