Fix UIMarkdown with AuditMode #18221
Conversation
…/pabhoj/markdown_audit_mode
| @@ -92,7 +92,7 @@ WUX::Documents::Paragraph MarkdownToXaml::_CurrentParagraph() | |||
| { | |||
| _lastParagraph.TextIndent(-WidthOfBulletPoint); | |||
| } | |||
| _lastParagraph.Margin(WUX::ThicknessHelper::FromLengths(IndentWidth * _indent, 0, 0, 0)); | |||
| _lastParagraph.Margin(WUX::ThicknessHelper::FromLengths(gsl::narrow<double>(IndentWidth) * _indent, 0, 0, 0)); | |||
There was a problem hiding this comment.
This probably works, but is most likely not what you actually intended.
What gsl::narrow does is something like that:
let narrowed = (TargetType)original_value;
let converted_back = (OriginalType)narrowed;
if (converted_back != original_value) {
throw;
}
return narrowed;In other words, this will throw if there was no accurate representation as a double. This is easy to show with floats, because if you run gsl::narrow<float>(0xffffffff) it'll throw as it'll actually turn into 4.2949673e9 which is nowhere near 4294967295.
The solution is to just use static_cast.
| @@ -8,12 +8,12 @@ namespace til // Terminal Implementation Library. Also: "Today I Learned" | |||
| template<typename T> | |||
| struct property | |||
| { | |||
| explicit constexpr property(auto&&... args) : | |||
| explicit constexpr property(auto&&... args) noexcept : | |||
There was a problem hiding this comment.
This should be something like noexcept(std::is_nothrow_constructible_v<T, decltype(args)...>, aka:
𓀀 𓁐 𓁛 𓁼 𓄿 𓆄 𓆑 𓆟 𓆣 𓆭 𓈝 𓊝 𓊩 𓊯𓋑 𓌪 𓌳 𓍯 𓎵
| _value{ std::forward<decltype(args)>(args)... } {} | ||
|
|
||
| property& operator=(const property& other) = default; | ||
|
|
||
| T operator()() const noexcept | ||
| T operator()() const noexcept(noexcept(static_cast<T>(_value))) |
There was a problem hiding this comment.
I believe this should be std::is_nothrow_copy_constructible, but I think it would be even more ideal for us to just return const T& here and leave the unconditional noexcept.
Summary of the Pull Request
Adds the UIMarkdown library to AuditMode
PR Checklist