-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update utils.py #2395
base: main
Are you sure you want to change the base?
Update utils.py #2395
Conversation
fix the bug! when running "dataset = naip & chesapeake" from https://torchgeo.readthedocs.io/en/stable/tutorials/getting_started.html; it generates an err: ValueError: Bounding boxes BoundingBox(minx=440055.0, maxx=446085.0, miny=4295910.600000001, maxy=4303429.2, mint=1541260800.0, maxt=1541347199.999999) and BoundingBox(minx=402172.2959946942, maxx=532531.001762003, miny=4244077.01658443, maxy=4414067.523828775, mint=1356969600.0, maxt=1388505599.999999) do not overlap. This new request fix the err .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I am unable to reproduce the issue you reported, the tutorials all pass
- The fix is incorrect, you are performing a union, not an intersection
您的邮件已经收到。谢谢! 吕
|
the above code:
|
Can you tell me how to reproduce the error you are reporting? When I run the tutorial on Google Colab everything runs without issue. Did you modify the tutorial in any way? |
`import os from torchgeo.datasets import NAIP, ChesapeakeDE, stack_samples naip_root = os.path.join(tempfile.gettempdir(), 'naip') naip_url = ( tiles = [ for tile in tiles: naip = NAIP(naip_root) chesapeake_root = os.path.join(tempfile.gettempdir(), 'chesapeake') chesapeake = ChesapeakeDE(chesapeake_root, crs=naip.crs, res=naip.res, download=True) dataset = naip & chesapeake ` |
I'm not able to reproduce the error, and all of the tests are failing with this change. Can you try to reproduce the error on Google Colab? |
@lvxiaojie111 are you still seeing this issue? If so, how can I reproduce it? If not, then maybe we can close this PR. |
I can only reproduce this problem on Windows. I'm trying to figure out how to reproduce this problem for you. |
I'm also not able to reproduce the problem on Windows: https://github.com/microsoft/torchgeo/actions/runs/11931373820/job/33254106741?pr=2419 |
fix the bug!
when running code:
dataset = naip & chesapeake
from https://torchgeo.readthedocs.io/en/stable/tutorials/getting_started.html;
it generates an err:
ValueError: Bounding boxes BoundingBox(minx=440055.0, maxx=446085.0, miny=4295910.600000001, maxy=4303429.2, mint=1541260800.0, maxt=1541347199.999999) and BoundingBox(minx=402172.2959946942, maxx=532531.001762003, miny=4244077.01658443, maxy=4414067.523828775, mint=1356969600.0, maxt=1388505599.999999) do not overlap.
This new request fix the err .