Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgui]: Update to 1.91.5 #42244

Merged
merged 9 commits into from
Nov 22, 2024
Merged

[imgui]: Update to 1.91.5 #42244

merged 9 commits into from
Nov 22, 2024

Conversation

tomconder
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@BillyONeal
Copy link
Member

I cancelled the build because all triplets except x64-windows report failures and we're destroying the westus3 test VMs.

@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Nov 20, 2024
- GetKeyIndex() is a no-op since 1.87; see ocornut/imgui#5979 (comment)
@tomconder
Copy link
Contributor Author

The patch for hello-imgui is based on this upstream commit:
pthom/hello_imgui@3ba369a

The patch for imgui-node-editor is based on the comment from the imgui maintainer that GetKeyIndex() is, in fact, a no-op since 1.87. See:
ocornut/imgui#5979 (comment)

@BillyONeal
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tomconder
Copy link
Contributor Author

tomconder commented Nov 21, 2024

The milerius-sfml-imgui port is problematic. Its source repository consists of 3 files forked from the imgui-sfml repo in 2018.

Elias Daler, the author of imgui-sfml, has asked the repo owner to add his name to the license. In my opinion it would not feel right to copy updates from imgui-sfml into a patch for milerius-sfml-imgui without honoring this request.

I recommend removing the milerius-sfml-imgui port. Users should use the imgui-sfml port instead.

Update: in a search I found no ports that have milerius-sfml-imgui as a dependency.

Please advise.

- remove unmaintained fork of imgui-sfml from 2018
- removed port uses the imgui io keyboard API which was deprecated in 2022 and removed in v1.19.5; see release notes: https://github.com/ocornut/imgui/releases/tag/v1.91.5
@dg0yt
Copy link
Contributor

dg0yt commented Nov 22, 2024

I recommend removing the milerius-sfml-imgui port. Users should use the imgui-sfml port instead.

Upstream code is unmaintained since 2018. Zero forks, one star, one author.

Please also remove its entry from scripts/ci.baseline.txt.

@tomconder
Copy link
Contributor Author

Done. Removed entry from ci.baseline.txt

@tomconder
Copy link
Contributor Author

tomconder commented Nov 22, 2024

Patch for imgui-sfml based on PRs from that repo:

@BillyONeal BillyONeal merged commit ab65510 into microsoft:master Nov 22, 2024
17 checks passed
@BillyONeal
Copy link
Member

BillyONeal commented Nov 22, 2024

Thanks for the update and deindexing the broken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants