-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imgui]: Update to 1.91.5 #42244
[imgui]: Update to 1.91.5 #42244
Conversation
I cancelled the build because all triplets except x64-windows report failures and we're destroying the westus3 test VMs. |
- use upstream commit; see pthom/hello_imgui@3ba369a
- GetKeyIndex() is a no-op since 1.87; see ocornut/imgui#5979 (comment)
The patch for hello-imgui is based on this upstream commit: The patch for imgui-node-editor is based on the comment from the imgui maintainer that GetKeyIndex() is, in fact, a no-op since 1.87. See: |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
The milerius-sfml-imgui port is problematic. Its source repository consists of 3 files forked from the imgui-sfml repo in 2018. Elias Daler, the author of imgui-sfml, has asked the repo owner to add his name to the license. In my opinion it would not feel right to copy updates from imgui-sfml into a patch for milerius-sfml-imgui without honoring this request. I recommend removing the milerius-sfml-imgui port. Users should use the imgui-sfml port instead. Update: in a search I found no ports that have milerius-sfml-imgui as a dependency. Please advise. |
- remove unmaintained fork of imgui-sfml from 2018 - removed port uses the imgui io keyboard API which was deprecated in 2022 and removed in v1.19.5; see release notes: https://github.com/ocornut/imgui/releases/tag/v1.91.5
Upstream code is unmaintained since 2018. Zero forks, one star, one author. Please also remove its entry from |
Done. Removed entry from ci.baseline.txt |
Patch for imgui-sfml based on PRs from that repo:
|
Thanks for the update and deindexing the broken! |
The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.