Support User Defines and Macro References AB Experiment #12844
+726
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
830f513
to
9357de0
Compare
sean-mcmanus
previously requested changes
Oct 17, 2024
Colengms
requested changes
Oct 17, 2024
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
9357de0
to
2516fa6
Compare
Extension/test/scenarios/SingleRootProject/tests/lmTool.test.ts
Outdated
Show resolved
Hide resolved
Colengms
previously requested changes
Oct 19, 2024
benmcmorran
reviewed
Oct 22, 2024
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
2516fa6
to
3560e44
Compare
kuchungmsft
changed the title
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
3560e44
to
e6721bd
Compare
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
e6721bd
to
c03a944
Compare
bobbrow
reviewed
Oct 28, 2024
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
c03a944
to
2d50ccb
Compare
Colengms
reviewed
Oct 28, 2024
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
2 times, most recently
from
cf72c95
to
f449793
Compare
kuchungmsft
commented
Nov 13, 2024
| telemetryProperties["compilerArgumentCount"] = projectContext.result.fileContext.compilerArgs.length.toString(); | ||
| telemetryProperties["filteredCompilerArgumentCount"] = filteredcompilerArguments.length.toString(); | ||
| telemetryProperties["compilerUserDefinesRelavantCount"] = projectContext.result.fileContext.compilerUserDefinesRelavant.length.toString(); | ||
| telemetryProperties["targetArcompilerOriginalUserDefineCounthitecture"] = projectContext.result.fileContext.compilerOriginalUserDefineCount.toString(); |
There was a problem hiding this comment.
Typo: compilerOriginalUserDefineCount
| telemetryProperties["filteredCompilerArgumentCount"] = filteredcompilerArguments.length.toString(); | ||
| telemetryProperties["compilerUserDefinesRelavantCount"] = projectContext.result.fileContext.compilerUserDefinesRelavant.length.toString(); | ||
| telemetryProperties["targetArcompilerOriginalUserDefineCounthitecture"] = projectContext.result.fileContext.compilerOriginalUserDefineCount.toString(); | ||
| telemetryProperties["targetArchmacroReferenceCountitecture"] = projectContext.result.fileContext.macroReferenceCount.toString(); |
There was a problem hiding this comment.
Typo: macroReferenceCount
|
@kuchungmsft FYI, you should have permissions now to create a branch in our repo instead of from a fork (you may not have had that at the time of this PR creation though). |
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
2 times, most recently
from
bd47d76
to
caa3897
Compare
- Depends on cpptools' update to provide ProjectContextResult. - Added the following new traits - intellisense: compiler information disclaimer. - intellisenseBegin: to note the begin of IntelliSense information. - compilerArguments: a list of compiler command arguments that could affect Copilot generating completions. - directAsks: direct asking Copilot to do something instead of providing an argument. - intellisenseEnd: to note the end of IntelliSense information. - A/B Experimental flags - copilotcppTraits: boolean flag to enable cpp traits - copilotcppExcludeTraits: string array to exclude individual trait, i.e., compilerArguments. - copilotcppMsvcCompilerArgumentFilter: regex string to match compiler arguments for GCC. - copilotcppClangCompilerArgumentFilter: regex string to match compiler arguments for Clang. - copilotcppGccCompilerArgumentFilter: regex string to match compiler arguments for MSVC. - copilotcppCompilerArgumentDirectAskMap: a stringify map string to map arguments to direct ask statements.
- Depends on microsoft#12979 to merge first. - copilotcppMacroReferenceFilter: regex string to filter macro reference for telemetry. - Telemetry related to user defines and macro references. - Added new trait compilerUserDefines to note the relevant user defines to the editing file.
kuchungmsft
force-pushed
the
kuchung/ProvideCompilerDefinesArgumentsTrait
branch
from
caa3897
to
2672a83
Compare
kuchungmsft
changed the title
kuchungmsft
changed the base branch from
main
to
kuchung/SupportCompilerArgumentAB
kuchungmsft
force-pushed
the
kuchung/SupportCompilerArgumentAB
branch
3 times, most recently
from
7a72866
to
4758e15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support A/B Compiler Arguments Traits