Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven.terminal.useJavaHome looks at java.home #1041

Open
ghost opened this issue Jul 29, 2024 · 1 comment
Open

maven.terminal.useJavaHome looks at java.home #1041

ghost opened this issue Jul 29, 2024 · 1 comment
Assignees

Comments

@ghost
Copy link

ghost commented Jul 29, 2024

Describe the bug
The setting maven.terminal.useJavaHome looks at java.home which is deprecated and should look for java.jdt.ls.java.home

To Reproduce
Steps to reproduce the behavior:

  1. Configure java.jdt.ls.java.home in a workspace settings file
  2. Configure maven.terminal.useJavaHome to true in the same settings file
  3. use maven command

Expected behavior
The maven plugin would check the current VS Code java home setting.

Environments (please complete the following information as much as possible):
Version: 1.91.1 (user setup)
Commit: f1e16e1e6214d7c44d078b1f0607b2388f29d729
Date: 2024-07-09T22:06:49.809Z
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Windows_NT x64 10.0.22631

Screenshots

Additional context
Developing Java projects that use installations of Java, Tomcat and Maven relative to my workspace.

@testforstephen testforstephen self-assigned this Aug 8, 2024
@cypher256
Copy link

Considering why java.home was changed to java.jdt.ls.java.home, Maven should avoid using java.jdt.ls.java.home.
Also, in the near future RedHat's embedded JRE will be version 21, so using java.jdt.ls.java.home will be confusing.

Related issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants