Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected inline values #400

Closed
roblourens opened this issue Jul 23, 2024 · 6 comments · Fixed by #409
Closed

Unexpected inline values #400

roblourens opened this issue Jul 23, 2024 · 6 comments · Fixed by #409
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@roblourens
Copy link
Member

roblourens commented Jul 23, 2024

Testing #396

Just noticing some values that don't seem helpful to annotate inline. Not sure whether it's expected or not.

The import statement

Image

The pop method

Image

@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 23, 2024
@roblourens
Copy link
Member Author

x is a global variable, and also a class member and an argument for the lambda, but those are annotated with the global value
This also shows the Cls value which doesn't seem helpful

Image

@roblourens
Copy link
Member Author

Just another example of showing a method as an inline value, I think that will be very noisy in typical python code

Image

@luabud
Copy link
Member

luabud commented Jul 24, 2024

@paulacamargo25 @karthiknadig we should probably make inline values disabled by default for now? I think we need to figure out the criteria for showing these inline values, or potentially format them differently

@paulacamargo25 paulacamargo25 added bug Issue identified by VS Code Team member as probable bug and removed triage-needed Needs assignment to the proper sub-team labels Jul 25, 2024
@paulacamargo25
Copy link
Contributor

Almost all the bugs here will be resolved in #409.

#400 (comment) this one seems to be a bug in vscode, i wll create an issue.

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jul 26, 2024

we should probably make inline values disabled by default for now? I think we need to figure out the criteria for showing these inline values, or potentially format them differently

I agree, I just debugged some of my Python code, and there were way too many inline values, to the point i looked for a way to turn it off completely.

I do however think this will be very useful for beginners, wanting to see values/variables when debugging.

@paulacamargo25
Copy link
Contributor

paulacamargo25 commented Jul 26, 2024

To verify this, set showPythonInlineValues to true.

@DonJayamanne DonJayamanne added the verified Verification succeeded label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants