Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

Package JSON updates #408

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Package JSON updates #408

wants to merge 2 commits into from

Conversation

andreamah
Copy link
Contributor

Description:

Added description for disallowing virtual workspaces
Closes #400

Added description for workspace trust limitation
Closes #399

Added button on editor title for "deploy to device".
image

Closes #391

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing:

Tested using the button to deploy to device and it seemed to run the command correctly. I don't have a device with me at the moment, so I'd appreciate if someone could test this out.

👀 @vandyliu @xnkevinnguyen

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@FrankSAURET
Copy link

It work fin thank's.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abmahdy abmahdy Awaiting requested review from abmahdy abmahdy is a code owner

@adclements adclements Awaiting requested review from adclements adclements is a code owner

@isadorasophia isadorasophia Awaiting requested review from isadorasophia

@sagarmanchanda sagarmanchanda Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner

@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support virtual workspaces Support Workspace Trust Feature Request: Deploy to device button
2 participants
@andreamah @FrankSAURET