From a55484d3c3ccadfc5144c5aa48bdefcb803a1f97 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Thu, 19 Oct 2023 17:41:43 -0700 Subject: [PATCH] Fix for stack overflow on dispose (#22263) Closes https://github.com/microsoft/vscode-python/issues/22261 --- src/client/tensorBoard/tensorBoardUsageTracker.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/client/tensorBoard/tensorBoardUsageTracker.ts b/src/client/tensorBoard/tensorBoardUsageTracker.ts index b88e416a113f..d1b21473677f 100644 --- a/src/client/tensorBoard/tensorBoardUsageTracker.ts +++ b/src/client/tensorBoard/tensorBoardUsageTracker.ts @@ -27,9 +27,7 @@ export class TensorBoardUsageTracker implements IExtensionSingleActivationServic @inject(IDisposableRegistry) private disposables: IDisposableRegistry, @inject(TensorBoardPrompt) private prompt: TensorBoardPrompt, @inject(TensorboardExperiment) private readonly experiment: TensorboardExperiment, - ) { - disposables.push(this); - } + ) {} public dispose(): void { Disposable.from(...this.disposables).dispose();