ipykernel never installs (possibly because it tried installing using the python terminal)

[mjbvz]

Issue Type: Bug

Repro

1. Install python extension
2. Run something in the python terminal
3. Now open python interactive window
4. See alert about installing ipykernel
5. Click button to install

Bug
Loading forever.

If you look more closely at the terminal in the screenshot, it seems it tried to install ipykernel using the python terminal:

>>> /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/matb/.vscode-insiders/extensions/ms-python.python-2020.9.114305/pythonFiles/pyvsc-run-isolated.py /Users/matb/.vscode-insiders/extensions/ms-python.python-2020.9.114305/pythonFiles/shell_exec.py /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/matb/.vscode-insiders/extensions/ms-python.python-2020.9.114305/pythonFiles/pyvsc-run-isolated.py pip install -U ipykernel --user /var/folders/5d/nlg411_s0570wmycdwkgqrf40000gn/T/tmp-50669KGia1cCmwSTb.log
  File "<stdin>", line 1
    /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/matb/.vscode-insiders/extensions/ms-python.python-2020.9.114305/pythonFiles/pyvsc-run-isolated.py /Users/matb/.vscode-insiders/extensions/ms-python.python-2020.9.114305/pythonFiles/shell_exec.py /Applications/Xcode.app/Contents/Developer/usr/bin/python3 /Users/matb/.vscode-insiders/extensions/ms-python.python-2020.9.114305/pythonFiles/pyvsc-run-isolated.py pip install -U ipykernel --user /var/folders/5d/nlg411_s0570wmycdwkgqrf40000gn/T/tmp-50669KGia1cCmwSTb.log
    ^
SyntaxError: invalid syntax
>>> 

Extension version: 2020.9.114305
VS Code version: Code - Insiders 1.51.0-insider (7a3bdf4ee9588755d447aa1c3b5db4a123fc11a9, 2020-10-23T07:32:22.213Z)
OS version: Darwin x64 19.6.0

[joyceerhl]

Thanks @mjbvz. We'd want to change the behavior of getTerminalService here:

vscode-python/src/client/common/installer/moduleInstaller.ts

Lines 35 to 37 in 4860acd

	const terminalService = this.serviceContainer
	.get<ITerminalServiceFactory>(ITerminalServiceFactory)
	.getTerminalService(uri);

Problem here is we're reusing terminals without checking whether they're running some other program. We'd want to either validate the target terminal or always create a new terminal. I'm removing the data science tag here as I think this affects any product install.

[brettcannon]

Solution will be related to #7206.

[brettcannon]

Should be solved as part of #2997 .

[karrtikr]

Closing as dup of #2997.