Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable 'autoComplete.addBrackets' for decorators #17203

Closed
brettcannon opened this issue Sep 1, 2021 Discussed in #16502 · 3 comments
Closed

Option to disable 'autoComplete.addBrackets' for decorators #17203

brettcannon opened this issue Sep 1, 2021 Discussed in #16502 · 3 comments
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. community ask Feature request that the community expressed interest in feature-request Request for new features or functionality

Comments

@brettcannon
Copy link
Member

Discussed in #16502

Originally posted by brettcannon June 16, 2021
I really like the python.autoComplete.addBrackets option as it's almost always what I would have done anyway. One area where it's not useful though is for decorators. Especially when writing multiple overload this can get annoying pretty fast.

Would it be possible to not insert brackets if the suggestion item follows @, either as default or an additional option?

Originally posted by @cdce8p in a discussion

@brettcannon brettcannon added feature-request Request for new features or functionality area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs decision labels Sep 1, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 1, 2021
@brettcannon brettcannon removed the triage-needed Needs assignment to the proper sub-team label Sep 1, 2021
@brettcannon
Copy link
Member Author

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 5 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@brettcannon brettcannon added needs community feedback Awaiting community feedback and removed needs FR policy labels Sep 1, 2021
@brettcannon
Copy link
Member Author

Thank you to everyone who upvoted this issue! Since the community showed interest in this feature request we will leave this issue open as something to consider implementing at some point in the future.

We do encourage people to continue 👍 this issue as it helps us prioritize our work based on what the community seems to want the most.

@brettcannon brettcannon added community ask Feature request that the community expressed interest in needs proposal Need to make some design decisions and removed needs community feedback Awaiting community feedback labels Nov 1, 2021
@luabud
Copy link
Member

luabud commented Dec 14, 2023

autoComplete.addBrackets is no longer a supported setting. Our new language server, Pylance, supports python.analysis.completeFunctionParens instead. We have this issue tracked on the Pylance side: microsoft/pylance-release#4215, so closing this issue in favour of that :)

@luabud luabud closed this as not planned Won't fix, can't repro, duplicate, stale Dec 14, 2023
@github-actions github-actions bot removed the needs proposal Need to make some design decisions label Dec 14, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. community ask Feature request that the community expressed interest in feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants