Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure selecting interpreter on remote does not change user setting #17733

Closed
karrtikr opened this issue Oct 13, 2021 · 4 comments · Fixed by #17732
Closed

Ensure selecting interpreter on remote does not change user setting #17733

karrtikr opened this issue Oct 13, 2021 · 4 comments · Fixed by #17732
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@karrtikr
Copy link

See #17667 (comment)

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug needs PR area-environments Features relating to handling interpreter environments labels Oct 13, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 13, 2021
@karrtikr karrtikr added this to the October 2021 milestone Oct 13, 2021
@karrtikr karrtikr removed the triage-needed Needs assignment to the proper sub-team label Oct 13, 2021
@karrtikr karrtikr added the verification-needed Verification of issue is requested label Oct 25, 2021
@karrtikr
Copy link
Author

Verification steps:

  • Have no files or workspace opened.
  • Use Python: Select Interpreter and select one. Ensure python.defaultInterpreterPath appears in User settings
  • Select
  • Open a remote scenario.
  • Install latest Python extension in remote using Python: Switch to Insiders command.
  • Use Python: Select Interpreter and select one. Ensure python.defaultInterpreterPath is modified at Remote level and not User scope.

@rchiodo rchiodo added the verified Verification succeeded label Oct 26, 2021
@rchiodo
Copy link

rchiodo commented Oct 26, 2021

The user default is not used in remote, but it doesn't save the interpreter in the remote settings? Oh that only works if I don't open a folder in remote.

@karrtikr
Copy link
Author

karrtikr commented Oct 26, 2021

but it doesn't save the interpreter in the remote settings? Oh that only works if I don't open a folder in remote.

It should only save value to python.defaultInterpreterPath in remote settings if no folders are opened. Sounds like this is what you're describing?

@karrtikr karrtikr removed the verification-needed Verification of issue is requested label Oct 26, 2021
@rchiodo
Copy link

rchiodo commented Oct 26, 2021

Sounds like this is what you're describing?

Yeah that's what happened.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-environments Features relating to handling interpreter environments bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants