Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I disable shift-enter from sending to the interactive window, shift-enter sends Python code to inappropriate termninals. #18905

Closed
greazer opened this issue Apr 11, 2022 · 1 comment
Assignees
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug investigating We are looking into the cause of the issue

Comments

@greazer
Copy link
Member

greazer commented Apr 11, 2022

From a marketplace review (From: Not Specified on 3/18/2022). Here's the relevant comment:

"So that's a matter of opinion and doesn't necessarily justify one staring something. After all, in theory, if I don't like it I just disable the code that pipes things into notebooks when I hit shift -enter, back to four of five stars.

If you do that, and you have a python terminal running, you'll send (possibly incomplete) code into a python terminal if it is running. If I type exit, though. It'll still send code, to the specific terminal it thinks is the python terminal. Powershell was not amused by print('hello world'). You can even start an ipython kernel and send code in using shift enter to see what a decent cli interface feels like... well, except the fact that it messes up indentation on multiple lines of code. So it both feels like it's covering up a buggy part of the python implementation and it suggests a world where I could just flip on an ipython terminal and use that."

@greazer greazer added bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug labels Apr 11, 2022
@greazer greazer transferred this issue from microsoft/vscode-jupyter Apr 11, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 11, 2022
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug area-terminal triage and removed triage-needed Needs assignment to the proper sub-team labels Apr 12, 2022
@karrtikr karrtikr added investigating We are looking into the cause of the issue and removed triage labels Apr 12, 2022
@karrtikr
Copy link

karrtikr commented Apr 19, 2022

Here's the scenario which user describes:

image

The thing is we cannot know if the Python interactive session in the terminal is exited or not, so we simply keep sending the selection and this is expected.

well, except the fact that it messes up indentation on multiple lines of code

Regarding the support for IPython, we do have #8945 #17172 opened where we plan to help with the indentation issues so users can launch their terminals using IPython instead and would not have this problem. Closing in favor of that. Here's a workaround that can work for the user: #8945 (comment).

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug investigating We are looking into the cause of the issue
Projects
None yet
Development

No branches or pull requests

3 participants