Pytest discovery fails with 'Function' object has no attribute 'fspath'

[gjoseph92]

Type: Bug

Behaviour

Expected vs. Actual

Test discovery is failing with this exception from

vscode-python/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py

Line 182 in d3dd832

testroot, relfile = _split_fspath(str(item.fspath), fileid, item)

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/_pytest/main.py", line 667, in perform_collect
INTERNALERROR>     hook.pytest_collection_modifyitems(
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 95, in pytest_collection_modifyitems
INTERNALERROR>     test, parents = self.parse_item(item)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 80, in parse_item
INTERNALERROR>     return parse_item(item)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py", line 182, in parse_item
INTERNALERROR>     testroot, relfile = _split_fspath(str(item.fspath), fileid, item)
INTERNALERROR> AttributeError: 'Function' object has no attribute 'fspath'

However, pytest collection itself is working fine:

(distributed-test) gabe ~/distributed ‹main› » pytest --collect-only
...
======================================================================== 3460 tests collected in 7.06s =========================================================================

Steps to reproduce:

Sorry, I don't have a minimal reproducer. But hopefully I do have a reproducer at least. I'm seeing this with https://github.com/dask/distributed, and can reproduce it with a fresh clone in a fresh environment.

1. git clone [email protected]:dask/distributed.git
2. git checkout 601608cba8ce6df3d0780994ed25fa5cf2b30e24 (just to be sure for reproducability; don't think it's related to this commit though)
3. mamba env create -n distributed-test -f continuous_integration/environment-3.9.yaml
4. conda activate distributed-test
5. pip install --no-deps -e .
6. pytest --collect-only (just to confirm)
7. code .
8. Click on the testing pane and click refresh. It takes a couple minutes, but eventually test discovery fails, and outputs the error shown above.

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.9.16
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Conda
• Value of the python.languageServer setting: Pylance

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

LSP Notebooks experiment is enabled
LSP Notebooks interactive window support is enabled
> ~/miniconda3/envs/distributed-test/bin/python -I ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/interpreterInfo.py
Python interpreter path: ~/miniconda3/envs/distributed-test/bin/python
Starting Pylance language server.
> conda run -n distributed-test --no-capture-output python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/printEnvVariables.py
> conda run -n distributed-test --no-capture-output python ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py ~/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir . -s --cache-clear
cwd: .
[ERROR 2023-2-10 13:9:37.716]: Error discovering pytest tests:
 [n [Error]: �[1m============================= test session starts ==============================�[0m
platform darwin -- Python 3.9.16, pytest-7.2.2, pluggy-1.0.0 -- /Users/gabe/miniconda3/envs/distributed-test/bin/python
cachedir: .pytest_cache
rootdir: /Users/gabe/distributed, configfile: setup.cfg
plugins: timeout-2.1.0, rerunfailures-11.1.2, cov-4.0.0, repeat-0.9.1
timeout: 300.0s
timeout method: thread
timeout func_only: False
�[1mcollecting ... �[0mcollected 3460 items / 8 skipped

<Package tests>
  <Module test_dask_scheduler.py>
    <Function test_defaults>
    <Function test_hostport>
    <Function test_no_dashboard>
    <Function test_dashboard>
    <Function test_dashboard_non_standard_ports>
    <Function test_multiple_protocols>

... [I'm deleting a few thousand lines of successful test discovery here] ...

  <Function test_task_releases_resources[long-running-RescheduleEvent]>
  <Function test_task_with_dependencies_acquires_resources>
  <Function test_resumed_task_releases_resources[executing-ExecuteSuccessEvent]>
  <Function test_resumed_task_releases_resources[executing-ExecuteFailureEvent]>
  <Function test_resumed_task_releases_resources[executing-RescheduleEvent]>
  <Function test_resumed_task_releases_resources[long-running-ExecuteSuccessEvent]>
  <Function test_resumed_task_releases_resources[long-running-ExecuteFailureEvent]>
  <Function test_resumed_task_releases_resources[long-running-RescheduleEvent]>
  <Function test_clean_log>
    Test that brand new workers start with a clean log
  <Function test_running_task_in_all_running_tasks[executing]>
  <Function test_running_task_in_all_running_tasks[long-running]>
  <Function test_done_task_not_in_all_running_tasks[executing-ExecuteSuccessEvent]>
  <Function test_done_task_not_in_all_running_tasks[executing-ExecuteFailureEvent]>
  <Function test_done_task_not_in_all_running_tasks[executing-RescheduleEvent]>
  <Function test_done_task_not_in_all_running_tasks[long-running-ExecuteSuccessEvent]>
  <Function test_done_task_not_in_all_running_tasks[long-running-ExecuteFailureEvent]>
  <Function test_done_task_not_in_all_running_tasks[long-running-RescheduleEvent]>
  <Function test_done_resumed_task_not_in_all_running_tasks[executing-ExecuteSuccessEvent]>
  <Function test_done_resumed_task_not_in_all_running_tasks[executing-ExecuteFailureEvent]>
  <Function test_done_resumed_task_not_in_all_running_tasks[executing-RescheduleEvent]>
  <Function test_done_resumed_task_not_in_all_running_tasks[long-running-ExecuteSuccessEvent]>
  <Function test_done_resumed_task_not_in_all_running_tasks[long-running-ExecuteFailureEvent]>
  <Function test_done_resumed_task_not_in_all_running_tasks[long-running-RescheduleEvent]>
  <Function test_gather_dep_failure>
    Simulate a task failing to unpickle when it reaches the destination worker after
    a flight.
    
    See also test_worker_memory.py::test_workerstate_fail_to_pickle_flight,
    where the task instead is gathered successfully, but fails to spill.
  <Function test_transfer_incoming_metrics>
  <Function test_throttling_does_not_affect_first_transfer>
  <Function test_message_target_does_not_affect_first_transfer_on_different_worker>
  <Function test_throttle_incoming_transfers_on_count_limit>
  <Function test_throttling_incoming_transfer_on_transfer_bytes_same_worker>
  <Function test_throttling_incoming_transfer_on_transfer_bytes_different_workers>
  <Function test_do_not_throttle_connections_while_below_threshold>
  <Function test_throttle_on_transfer_bytes_regardless_of_threshold>
  <Function test_worker_nbytes[executing]>
  <Function test_worker_nbytes[long-running]>
  <Function test_fetch_count>
  <Function test_task_counter>
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/_pytest/main.py", line 667, in perform_collect
INTERNALERROR>     hook.pytest_collection_modifyitems(
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 95, in pytest_collection_modifyitems
INTERNALERROR>     test, parents = self.parse_item(item)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 80, in parse_item
INTERNALERROR>     return parse_item(item)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py", line 182, in parse_item
INTERNALERROR>     testroot, relfile = _split_fspath(str(item.fspath), fileid, item)
INTERNALERROR> AttributeError: 'Function' object has no attribute 'fspath'
INTERNALERROR> 
INTERNALERROR> During handling of the above exception, another exception occurred:
INTERNALERROR> 
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/_pytest/main.py", line 270, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/_pytest/main.py", line 323, in _main
INTERNALERROR>     config.hook.pytest_collection(session=session)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/_pytest/main.py", line 334, in pytest_collection
INTERNALERROR>     session.perform_collect()
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/_pytest/main.py", line 671, in perform_collect
INTERNALERROR>     hook.pytest_collection_finish(session=self)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_hooks.py", line 265, in __call__
INTERNALERROR>     return self._hookexec(self.name, self.get_hookimpls(), kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_manager.py", line 80, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 60, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_result.py", line 60, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/site-packages/pluggy/_callers.py", line 39, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 110, in pytest_collection_finish
INTERNALERROR>     test, parents = self.parse_item(item)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 80, in parse_item
INTERNALERROR>     return parse_item(item)
INTERNALERROR>   File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py", line 182, in parse_item
INTERNALERROR>     testroot, relfile = _split_fspath(str(item.fspath), fileid, item)
INTERNALERROR> AttributeError: 'Function' object has no attribute 'fspath'

�[32m======================== �[32m3460 tests collected�[0m�[32m in 27.25s�[0m�[32m ========================�[0m

Traceback (most recent call last):
  File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py", line 26, in <module>
    runpy.run_path(module, run_name="__main__")
  File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/runpy.py", line 288, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/runpy.py", line 97, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/Users/gabe/miniconda3/envs/distributed-test/lib/python3.9/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/run_adapter.py", line 22, in <module>
    main(tool, cmd, subargs, toolargs)
  File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/__main__.py", line 99, in main
    parents, result = run(toolargs, **subargs)
  File "/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 47, in discover
    raise Exception("pytest discovery failed (exit code {})".format(ec))
Exception: pytest discovery failed (exit code 3)
ERROR conda.cli.main_run:execute(47): `conda run python /Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/get_output_via_markers.py /Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir /Users/gabe/distributed -s --cache-clear` failed. (See above for error)

	at ChildProcess.<anonymous> (/Users/gabe/.vscode/extensions/ms-python.python-2023.4.1/out/client/extension.js:2:244860)
	at Object.onceWrapper (node:events:646:26)
	at ChildProcess.emit (node:events:526:28)
	at maybeClose (node:internal/child_process:1092:16)
	at Socket.<anonymous> (node:internal/child_process:451:11)
	at Socket.emit (node:events:526:28)
	at Pipe.<anonymous> (node:net:687:12)]
> conda info --json
Send text to terminal: conda activate distributed-test

User Settings

venvFolders: "<placeholder>"

languageServer: "Pylance"

linting
• flake8Enabled: true

formatting
• provider: "black"

testing
• pytestEnabled: true

Extension version: 2023.4.1
VS Code version: Code 1.76.0 (92da9481c0904c6adfe372c12da3b7748d74bdcb, 2023-03-01T10:23:45.993Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: No

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	5, 6, 6
Memory (System)	32.00GB (0.08GB free)
Process Argv	. --crash-reporter-id 886611b4-5fa0-474f-bcba-14a7e9edd8e3
Screen Reader	no
VM	0%

[eleanorjboyd]

can you try this recommendation from #20666

Can you try the following from a terminal outside of VS Code?
cd
conda activate
code .

from here now run test discovery in the vscode window which pops up. Thanks

[carlosluis]

I'm also experiencing this issue. Exactly as described by the OP

The solution of launching vscode within a terminal where the conda env is already activated did not work for me.

do you have any other suggestions to try?

[eleanorjboyd]

Hello! Trying to repro and followed the steps up to number 4 but conda cannot find the environment. I tried to use a new terminal window and the same window but it was not in the list of environments conda could find. I am not very familiar with Mamba so could you clarify what steps I am missing to activate that conda environment. Thanks

[gjoseph92]

@eleanorjboyd that's odd. Try again just using conda for everything? Conda vs mamba shouldn't matter; mamba is just a bit faster.

[eleanorjboyd]

Hi! We are wrapping up a rewrite on testing infrastructure which is aimed at improving buggy behavior and making pytest work in a more native way. I will be testing discovery in regard to many issues we have in this space (symlinks, conda, discovery etc) on the rewrite to see what issues still exist. If you would like to help and test your issue out on the rewrite (steps explained below) that would be most helpful in understanding the ongoing shortcomings and helping me to determine and execute the next steps. Thanks!

To test you need to be on vscode insiders and then add this setting to your users settings.json "python.experiments.optInto": ["pythonTestAdapter"]. This is currently what is needed but we are in the process of switching all users to the rewrite but are doing so incrementally so if you do not have insiders, watch our release notes to get updated on when it will begin to hit stable. Thanks!

[shughes-uk]

Same error happens during collections while the experiment is active

INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/_pytest/main.py", line 672, in perform_collect
INTERNALERROR>     hook.pytest_collection_modifyitems(
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_hooks.py", line 433, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_manager.py", line 112, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_callers.py", line 155, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_result.py", line 108, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_callers.py", line 80, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 95, in pytest_collection_modifyitems
INTERNALERROR>     test, parents = self.parse_item(item)
INTERNALERROR>                     ^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 80, in parse_item
INTERNALERROR>     return parse_item(item)
INTERNALERROR>            ^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py", line 182, in parse_item
INTERNALERROR>     testroot, relfile = _split_fspath(str(item.fspath), fileid, item)
INTERNALERROR>                                           ^^^^^^^^^^^
INTERNALERROR> AttributeError: 'Function' object has no attribute 'fspath'
INTERNALERROR> 
INTERNALERROR> During handling of the above exception, another exception occurred:
INTERNALERROR> 
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/_pytest/main.py", line 270, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>                          ^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/_pytest/main.py", line 323, in _main
INTERNALERROR>     config.hook.pytest_collection(session=session)
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_hooks.py", line 433, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_manager.py", line 112, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_callers.py", line 155, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_result.py", line 108, in get_result
INTERNALERROR>     raise exc.with_traceback(exc.__traceback__)
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_callers.py", line 80, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/_pytest/main.py", line 334, in pytest_collection
INTERNALERROR>     session.perform_collect()
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/_pytest/main.py", line 676, in perform_collect
INTERNALERROR>     hook.pytest_collection_finish(session=self)
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_hooks.py", line 433, in __call__
INTERNALERROR>     return self._hookexec(self.name, self._hookimpls, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_manager.py", line 112, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
INTERNALERROR>            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_callers.py", line 116, in _multicall
INTERNALERROR>     raise exception.with_traceback(exception.__traceback__)
INTERNALERROR>   File "/Users/samanthahughes/miniconda3/envs/test-dask/lib/python3.11/site-packages/pluggy/_callers.py", line 80, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>           ^^^^^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 110, in pytest_collection_finish
INTERNALERROR>     test, parents = self.parse_item(item)
INTERNALERROR>                     ^^^^^^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 80, in parse_item
INTERNALERROR>     return parse_item(item)
INTERNALERROR>            ^^^^^^^^^^^^^^^^
INTERNALERROR>   File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py", line 182, in parse_item
INTERNALERROR>     testroot, relfile = _split_fspath(str(item.fspath), fileid, item)
INTERNALERROR>                                           ^^^^^^^^^^^
INTERNALERROR> AttributeError: 'Function' object has no attribute 'fspath'

�[32m======================== �[32m3596 tests collected�[0m�[32m in 1.33s�[0m�[32m =========================�[0m

Traceback (most recent call last):
  File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/get_output_via_markers.py", line 26, in <module>
    runpy.run_path(module, run_name="__main__")
  File "<frozen runpy>", line 291, in run_path
  File "<frozen runpy>", line 98, in _run_module_code
  File "<frozen runpy>", line 88, in _run_code
  File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/run_adapter.py", line 22, in <module>
    main(tool, cmd, subargs, toolargs)
  File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/__main__.py", line 99, in main
    parents, result = run(toolargs, **subargs)
                      ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 47, in discover
    raise Exception("pytest discovery failed (exit code {})".format(ec))
Exception: pytest discovery failed (exit code 3)
ERROR conda.cli.main_run:execute(47): `conda run python /Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/get_output_via_markers.py /Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir /Users/samanthahughes/programming/distributed -s --cache-clear .` failed. (See above for error)

    at ChildProcess.<anonymous> (/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python-2023.8.0/out/client/extension.js:2:241129)
    at Object.onceWrapper (node:events:628:26)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1112:16)
    at Socket.<anonymous> (node:internal/child_process:470:11)
    at Socket.emit (node:events:513:28)
    at Pipe.<anonymous> (node:net:757:14)

[shughes-uk]

The tests have a custom decorator around them, i suspect if that is the issue

[eleanorjboyd]

Can you set "python.analysis.logLevel": "Trace", in your user settings and then check for Experiment 'pythonTestAdapter' is active in your python logs? From the logs you sent it looks like you are still running the old test code.

Thanks!

[gnatecheng]

try
pip install --upgrade pytest==6.2.5

[eleanorjboyd]

Yes I think @gnatecheng is right with this fix here.

@shughes-uk one thing I notice is that the logs you sent are still running the old test adapter. I can see since they reference files "/Users/samanthahughes/.vscode-insiders/extensions/ms-python.python 2023.8.0/pythonFiles/testing_tools/adapter/pytest/_discovery.py" and all files in the folder testing_tools is the old code. Could you try again and make sure to change the setting to turn the experiment on, reload the vscode window and check for the following message in the logs? I put in a fix for this a month or two ago on the rewrite so if it still isn't working then it might be a larger issue. Thanks

You can confirm you have the rewrite enabled by setting "python.analysis.logLevel": "Trace", in your user settings, setting all logs to trace via the command palette, and then checking for Experiment 'pythonTestAdapter' is active in your python logs.

[guillaumedsde]

Hi, I am also getting this issue, I tried with the pythonTestAdapter experiment enabled, but I am getting a similar but different error, here are the logs from the OUTPUT tab for the python extension (I have redacted some information):

2023-08-22 14:53:37.825 [info] Telemetry level is off
2023-08-22 14:53:37.825 [info] Experiments are disabled, only manually opted experiments are active.
2023-08-22 14:53:37.825 [info] Experiment 'pythonTestAdapter' is active
2023-08-22 14:53:37.825 [error] Failed to initialize source map support in extension
2023-08-22 14:53:37.825 [info] Test server listening.
2023-08-22 14:53:37.825 [info] Python interpreter path: ./.venv/bin/python
2023-08-22 14:53:39.705 [info] > ./.venv/bin/python ~/.vscode/extensions/ms-python.python-2023.15.12301911/pythonFiles/linter.py -m mypy --follow-imports=silent --ignore-missing-imports --show-column-numbers --no-pretty ./tests/pipeline/test_airflow_local_settings.py
2023-08-22 14:53:39.706 [info] cwd: .
2023-08-22 14:53:41.514 [info] Starting Pylance language server.
2023-08-22 14:53:41.533 [info] ##########Linting Output - mypy##########

2023-08-22 14:53:41.533 [info] Success: no issues found in 1 source file

2023-08-22 14:53:44.255 [info] Discover tests for workspace name: REDACTED - uri: /home/REDACTED/git_repositories/REDACTED
2023-08-22 14:53:44.255 [info] Running discovery for pytest using the new test adapter.
2023-08-22 14:53:44.469 [info] > . ./.venv/bin/activate && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode/extensions/ms-python.python-2023.15.12301911/pythonFiles/printEnvVariables.py
2023-08-22 14:53:44.469 [info] shell: bash
2023-08-22 14:53:44.640 [info] > ./.venv/bin/python -m pytest -p vscode_pytest --collect-only --no-cov
2023-08-22 14:53:44.641 [info] cwd: .
2023-08-22 14:53:55.129 [info] Test server connected to a client.
2023-08-22 14:53:55.134 [info] Using result resolver for discovery
2023-08-22 14:53:55.134 [error] pytest test discovery error 
 Error Occurred, traceback: Traceback (most recent call last):
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.15.12301911/pythonFiles/vscode_pytest/__init__.py", line 327, in pytest_sessionfinish
    session_node: Union[TestNode, None] = build_test_tree(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.15.12301911/pythonFiles/vscode_pytest/__init__.py", line 368, in build_test_tree
    session_node = create_session_node(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.15.12301911/pythonFiles/vscode_pytest/__init__.py", line 512, in create_session_node
    node_path = get_node_path(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.15.12301911/pythonFiles/vscode_pytest/__init__.py", line 612, in get_node_path
    return getattr(node, "path", pathlib.Path(node.fspath))
AttributeError: 'Session' object has no attribute 'fspath'

2023-08-22 14:54:00.245 [info] Telemetry level is off
2023-08-22 14:54:00.245 [info] Experiments are disabled, only manually opted experiments are active.
2023-08-22 14:54:00.245 [info] Experiment 'pythonTestAdapter' is active
2023-08-22 14:54:00.256 [info] Test server listening.
2023-08-22 14:54:00.260 [info] Python interpreter path: ./.venv/bin/python
2023-08-22 14:54:00.583 [error] Failed to initialize source map support in extension
2023-08-22 14:54:03.431 [info] > ./.venv/bin/python ~/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/linter.py -m mypy --follow-imports=silent --ignore-missing-imports --show-column-numbers --no-pretty ./tests/pipeline/test_airflow_local_settings.py
2023-08-22 14:54:03.431 [info] cwd: .
2023-08-22 14:54:06.122 [info] Starting Pylance language server.
2023-08-22 14:54:06.671 [info] ##########Linting Output - mypy##########

2023-08-22 14:54:06.672 [info] Success: no issues found in 1 source file

2023-08-22 14:54:10.644 [info] Discover tests for workspace name: REDACTED - uri: /home/REDACTED/git_repositories/REDACTED
2023-08-22 14:54:10.645 [info] Running discovery for pytest using the new test adapter.
2023-08-22 14:54:10.848 [info] > . ./.venv/bin/activate && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/printEnvVariables.py
2023-08-22 14:54:10.849 [info] shell: bash
2023-08-22 14:54:11.019 [info] > ./.venv/bin/python -m pytest -p vscode_pytest --collect-only --no-cov
2023-08-22 14:54:11.020 [info] cwd: .
2023-08-22 14:54:17.656 [info] Test server connected to a client.
2023-08-22 14:54:17.658 [info] Using result resolver for discovery
2023-08-22 14:54:17.658 [error] pytest test discovery error 
 Error Occurred, traceback: Traceback (most recent call last):
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 306, in pytest_sessionfinish
    session_node: Union[TestNode, None] = build_test_tree(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 347, in build_test_tree
    session_node = create_session_node(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 490, in create_session_node
    node_path = get_node_path(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 590, in get_node_path
    return getattr(node, "path", pathlib.Path(node.fspath))
AttributeError: 'Session' object has no attribute 'fspath'

I have tried with pytest 7.4.0 and 7.3.2, to no avail.

[eleanorjboyd]

@guillaumedsde could you send over your settings and the specific test/test file you are running that produces this error? I looked through the pytest docs and saw that it is possible for the Session to have a null value since the superclass of Session is node and those parameters are not required but it seems like it might be a pytest bug. Will investigate more with the tests you suggest but might have to reach out to the pytest repo about this. Thanks

[guillaumedsde]

could you send over your settings

Here are my vscode user settings:

{
    "terminal.integrated.scrollback": 100000,
    "editor.bracketPairColorization.enabled": true,
    "editor.formatOnSave": true,
    "editor.formatOnType": true,
    "files.trimTrailingWhitespace": true,
    "files.autoSave": "afterDelay",
    "files.insertFinalNewline": true,
    "files.associations": {
      "compose*.{yaml,yml}": "dockercompose",
      "*.nomad.tpl": "terraform",
      "*.tpl": "gotmpl",
      "*.hcl": "terraform",
      "*.nomad": "terraform"
    },
    "update.mode": "none",
    "update.showReleaseNotes": false,
    "python.formatting.provider": "black",
    "python.languageServer": "Pylance",
    "python.linting.enabled": true,
    "python.linting.mypyEnabled": true,
    "python.linting.pylintEnabled": false,
    "python.testing.pytestEnabled": true,
    "[python]": {
      "editor.codeActionsOnSave": {
        "source.organizeImports": true
      }
    },
    "gitlens.plusFeatures.enabled": false,
    "docker.containers.label": "ContainerName",
    "workbench.editor.enablePreview": false,
    "workbench.startupEditor": "none",
    "git.autofetch": "all",
    "git.allowNoVerifyCommit": true,
    "workbench.cloudChanges.autoResume": "off",
    "workbench.cloudChanges.continueOn": "off",
    "workbench.enableExperiments": false,
    "python.experiments.enabled": true,
    "telemetry.telemetryLevel": "off",
    "npm.fetchOnlinePackageInfo": false,
    "settingsSync.keybindingsPerPlatform": false,
    "workbench.settings.enableNaturalLanguageSearch": false,
    "[javascript]": {
      "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "[json]": {
      "editor.defaultFormatter": "vscode.json-language-features"
    },
    "files.exclude": {
      "**/__pycache__": true,
      "**/.mypy_cache": true,
      "**/.pytest_cache": true
    },
    "[jsonc]": {
      "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "terminal.integrated.enablePersistentSessions": false,
    "isort.importStrategy": "fromEnvironment",
    "isort.check": true,
    "python.diagnostics.sourceMapsEnabled": true,
    "python.terminal.activateEnvInCurrentTerminal": true,
    "ruff.importStrategy": "fromEnvironment",
    "docker.containers.description": [],
    "docker.containers.sortBy": "Label",
    "docker.images.checkForOutdatedImages": false,
    "[dockercompose]": {
      "editor.defaultFormatter": "esbenp.prettier-vscode"
    },
    "editor.fontFamily": "Fira Code",
    "editor.fontLigatures": true,
    "terminal.integrated.fontFamily": "Fira Code",
    "gitlens.showWelcomeOnInstall": false,
    "gitlens.showWhatsNewAfterUpgrades": false,
    "typescript.disableAutomaticTypeAcquisition": true,
    "workbench.colorTheme": "Default Light+",
    "python.analysis.autoFormatStrings": true,
    "python.analysis.autoImportCompletions": true,
    "python.analysis.gotoDefinitionInStringLiteral": true,
    "python.analysis.inlayHints.pytestParameters": true,
    "python.analysis.persistAllIndices": true,
    "window.menuBarVisibility": "toggle",
    "extensions.autoUpdate": "onlyEnabledExtensions",
    "terminal.integrated.persistentSessionScrollback": 0,
    // https://github.com/microsoft/vscode-python/issues/20830#issuecomment-1604402947
    "python.experiments.optInto": ["pythonTestAdapter"],
    "python.analysis.logLevel": "Trace"
  }

and the specific test/test file you are running that produces this error

I can't really send source code sorry 😬 but even if I could I'm not sure how I can be sure which test source file causes this issue? cause it seems like even with Trace level logs no specific filename is logged:

2023-08-23 09:51:24.408 [info] Telemetry level is off
2023-08-23 09:51:24.408 [info] Experiments are disabled, only manually opted experiments are active.
2023-08-23 09:51:24.409 [info] Experiment 'pythonTestAdapter' is active
2023-08-23 09:51:24.409 [info] Test server listening.
2023-08-23 09:51:24.409 [info] Python interpreter path: ./.venv/bin/python
2023-08-23 09:51:24.412 [error] Failed to initialize source map support in extension
2023-08-23 09:51:28.214 [info] Starting Pylance language server.
2023-08-23 09:51:30.090 [info] Discover tests for workspace name: REDACTED - uri: /home/REDACTED/git_repositories/REDACTED
2023-08-23 09:51:30.090 [info] Running discovery for pytest using the new test adapter.
2023-08-23 09:51:30.418 [info] > . ./.venv/bin/activate && echo 'e8b39361-0157-4923-80e1-22d70d46dee6' && python ~/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/printEnvVariables.py
2023-08-23 09:51:30.418 [info] shell: bash
2023-08-23 09:51:30.555 [info] > ./.venv/bin/python -m pytest -p vscode_pytest --collect-only --no-cov
2023-08-23 09:51:30.556 [info] cwd: .
2023-08-23 09:51:36.478 [info] Discover tests for workspace name: REDACTED - uri: /home/REDACTED/git_repositories/REDACTED
2023-08-23 09:51:36.478 [info] Running discovery for pytest using the new test adapter.
2023-08-23 09:51:37.542 [info] Test server connected to a client.
2023-08-23 09:51:37.543 [info] Using result resolver for discovery
2023-08-23 09:51:37.543 [error] pytest test discovery error 
 Error Occurred, traceback: Traceback (most recent call last):
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 306, in pytest_sessionfinish
    session_node: Union[TestNode, None] = build_test_tree(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 347, in build_test_tree
    session_node = create_session_node(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 490, in create_session_node
    node_path = get_node_path(session)
  File "/home/REDACTED/.vscode/extensions/ms-python.python-2023.14.0/pythonFiles/vscode_pytest/__init__.py", line 590, in get_node_path
    return getattr(node, "path", pathlib.Path(node.fspath))
AttributeError: 'Session' object has no attribute 'fspath'

[eleanorjboyd]

Are you using any pytest plugins? If you could send your workspace settings for python.testing.pytestArgs that would be helpful. I have read through the pytest source code and although it can be None it should always be defined for pytest as outlined in the docs: https://docs.pytest.org/en/7.4.x/reference/reference.html#pytest.Session.path. For this reason it might be a pytest bug or you could have a plugin manipulating the session class / instance.

[guillaumedsde]

I don't think any of my plugins are related to pytest? perhaps coverage gutters, but I doubt it since it mostly reads the coverage report files? here is a full list of extensions I have installed:

❯ code --list-extensions
charliermarsh.ruff
eamodio.gitlens
exiasr.hadolint
github.vscode-github-actions
hashicorp.terraform
ms-azuretools.vscode-docker
ms-python.black-formatter
ms-python.isort
ms-python.mypy-type-checker
ms-python.python
ms-python.vscode-pylance
ms-vscode.live-server
njpwerner.autodocstring
redhat.vscode-yaml
ryanluker.vscode-coverage-gutters
streetsidesoftware.code-spell-checker
tamasfe.even-better-toml
timonwong.shellcheck
VisualStudioExptTeam.vscodeintellicode

and here is my workspace configuration (redacted in some places):

{
  "files.exclude": {
    "reports": true,
    ".ruff_cache": true
  },
  "[python]": {
    "editor.defaultFormatter": "ms-python.black-formatter",
    "editor.codeActionsOnSave": {
      "source.fixAll": true,
      "source.organizeImports": true
    }
  },
  "ruff.organizeImports": false,
  "ruff.importStrategy": "fromEnvironment",
  "ruff.args": ["--config=pyproject.toml"],
  "isort.importStrategy": "fromEnvironment",
  "python.testing.pytestEnabled": true,
  "python.testing.pytestArgs": ["--no-cov"],
  "mypy-type-checker.importStrategy": "fromEnvironment",
  "mypy-type-checker.args": [
    "--follow-imports=skip",
    "--ignore-missing-imports",
    "--show-column-numbers",
    "--no-pretty"
  ],
  "python.analysis.autoImportCompletions": true,
  "python.analysis.ignore": [
    "REDACTED"
  ],
  "cSpell.words": [
    "REDACTED"
  ],
  "python.analysis.persistAllIndices": true,
  "python.testing.pytestPath": "pytest",
}

Notably pytestArgs has value ["--no-cov"]

[eleanorjboyd]

Hi! Looked through the pytest docs and it is stated that one of these values is always set. If you do not have any plugins active then this is a bug on pytest specifically. You could try installing another version of pytest and see if that could work or post on pytest github as they are active there. Closing as the root cause is upstream. Thanks

[guillaumedsde]

👋 hello again

After (much) investigating, I think I might have found the cause of this issue: it seems to be cause by having the -p no:legacypath flag for pytest in the addopts config.

When I remove that flag, test discovery starts working once again

[eleanorjboyd]

glad you found that! Thanks for sharing the solution, I will investigate if we need to put in place a warning or something for this in the rewrite.

[samueljackson92]

Hi, I had the exact same error as @gjoseph92. I found I could fix it by changing line 182 of
.vscode/extensions/ms-python.python-2023.4.1/pythonFiles/testing_tools/adapter/pytest/_pytest_item.py

From:

testroot, relfile = _split_fspath(str(item.fspath), fileid, item)

To:

testroot, relfile = _split_fspath(str(item.path), fileid, item)

According to the pytest docs the fspath attribute is deprecated: https://docs.pytest.org/en/7.1.x/reference/reference.html#pytest.nodes.Node

After the change, VSCode correctly finds the tests and works as expected.

[eleanorjboyd]

Hello @samueljackson92, from the look of the line you changed that is part of the old code and so if you switch the re-write the fix should be in. To try it yourself, you need to be on the most recent release of the Python extension and add this setting to your users settings.json "python.experiments.optInto": ["pythonTestAdapter"].

You can confirm you have the rewrite enabled by setting "python.analysis.logLevel": "Trace", in your user settings then check for Experiment 'pythonTestAdapter' is active in your python logs.

Let me know if the rewrite fixes your issue. Thanks!

[samueljackson92]

Hi @eleanorjboyd I tried as you suggested, but unfortunately I still get a similar issue.

I see the Experiment 'pythonTestAdapter' is active in my logs. And I checked my Python plugin was up-to-date. I reloaded my vscode after making the changes and reconfigured my test suite.

I get a very similar error, but in a different place now:

 Error Occurred, traceback: Traceback (most recent call last):
  File "/home/ubuntu/.vscode-server/extensions/ms-python.python-2023.16.0/pythonFiles/vscode_pytest/__init__.py", line 323, in pytest_sessionfinish
    session_node: Union[TestNode, None] = build_test_tree(session)
  File "/home/ubuntu/.vscode-server/extensions/ms-python.python-2023.16.0/pythonFiles/vscode_pytest/__init__.py", line 364, in build_test_tree
    session_node = create_session_node(session)
  File "/home/ubuntu/.vscode-server/extensions/ms-python.python-2023.16.0/pythonFiles/vscode_pytest/__init__.py", line 508, in create_session_node
    node_path = get_node_path(session)
  File "/home/ubuntu/.vscode-server/extensions/ms-python.python-2023.16.0/pythonFiles/vscode_pytest/__init__.py", line 608, in get_node_path
    return getattr(node, "path", pathlib.Path(node.fspath))
AttributeError: 'Session' object has no attribute 'fspath'

Again, changing fspath -> path fixes the problem.

[eleanorjboyd]

You are saying that changing fspath here return getattr(node, "path", pathlib.Path(node.fspath)) is the fix? What this function should be doing is checking to try and get node.path and if this doesn't exist then gets node.fspath like described getattr(object, attribute_name, default_value). Let me know if this is where you are substituting to see success. Thanks

[carlosluis]

The solution from @samueljackson92 almost worked for me.
Additionally, I had to modify .vscode/extensions/ms-python.python-2023.4.1/pythonFiles/vscode_pytest/__init__.py line 590 from

return getattr(node, "path", pathlib.Path(node.fspath))

to

return getattr(node, "path", pathlib.Path(node.path))

After both changes, everything started working as intented.
@eleanorjboyd the setting "python.experiments.optInto": ["pythonTestAdapter"] did not solved the issue for me neither.

[eleanorjboyd]

Hello! Is someone able to confirm if this is fixed or not with the most recent version of insiders?

[carlosluis]

Sorry for the delay.

The new version of vscode-insiders (1.85.0) does not fix this issue.

Moreover, the fix I previously described (which I tested for insiders 1.80.0) seems to be incompatible with ms-python 2023.14.0

EDIT: also, the previous fix is not working for me anymore. It seems the path .vscode/extensions/ms-python.python-2023.4.1/pythonFiles/vscode_pytest/__init__.py no longer exists? I had to re-install version 2023.4.1 since the newer version was not working, and now that folder seems to have disappeared?

[eleanorjboyd]

Hi @carlosluis, thanks for getting back to me. Could you try ms-python 2023.20.0 or a version after 20? The 14 version was from 3 months ago and does not contain the fix. Secondly, are the logs the same with the error message? The file you referenced still exits but maybe the logs would tell you the new path. Thanks