Test discovery (pytest) fails in multi-root workspace: "payload UUID is not recognized" #21599
Assignees
Labels
area-testing
info-needed
Issue requires more information from poster
triage-needed
Needs assignment to the proper sub-team
Comments
Output for
|
github-actions
bot
added
the
triage-needed
Multiroot Workspace config file:
|
|
Also, I can't seem to turn any of the python experiments off, no matter what I do in the config file(s). Not sure if that's by design or a completely separate bug. |
|
Hello! Looking into these bugs you reported, I appreciate all your help! In terms of the experiment does |
github-actions
bot
added
the
info-needed
|
|
|
Looking into the UUID thing- one issue I have is I have trouble reproing it. Were you able to consistently get the error message |
github-actions
bot
added
the
info-needed
|
Yep. It comes up every time. I'll see if I can put together an example repo I can share, but not 100% I'll be able to do that easily. |
github-actions
bot
removed
the
info-needed
|
I created a sample repo you can use. When I run this on my Windows VSCode with a Linux Remote over SSH, I get the UUID errors. When I run it on my MacBook, I don't get the UUID errors but I still get the same behavior; only one project's tests show up in the explorer. Not sure why the error messages aren't showing up on the Mac and haven't tried testing locally in Windows. Hopefully this helps you find a solution! |
|
Thank you so much for the minimal repro! Much appreciated! |
|
Thank you again I am able to repro! Working on a fix |
|
Great!! Thanks! |
|
I'm actually running into "Error occurred because the payload UUID is not recognized" in a single workspace scenario ( |
|
We figured out the root cause- its a problem with when UUIDs are being deleted when the command to the test server is done running but not when the test server is done sending the response back. Therefore the UUID is being deleted pre-maturely. Working on a fix to have the actions to happen in the correct order. |
github-actions
bot
added
the
info-needed
I'm desperate! Using Vscode 1.80.1 and if I put: It gets greyed out and I see this message: 
What in heaven does it mean!? I can't access my tests!!! |
|
Well, well, I had to add this line specifically in to remote-server setting. And added that actually: This is not great. I really want to centralise all my settings in one place and make exceptions... well, when they are exceptions! Now I need to keep my eyes in every remote setup I have! I simply don't want any experimental stuff! You guys have created the Insider Vscode for what then? |
This was referenced Jul 17, 2023
If you ever find yourself in a situation where the latest extension version simply is not working, you can pin to an older version that does work for you until we manage to fix the bug causing you issues.
I wouldn't label this work as experimental. The new testing code passed through pre-release users and internal team testing. It's unfortunate this bug didn't trigger until more people were able to use the new code in more varied scenarios. It's behind an experiment flag so we can control the rollout in case of showstopper bugs, not because we are actively "experimenting" with our stable users (as I said, this code already passed various quality gates to even reach this level of rollout). If we had not used our experiment infrastructure to control this then this would have gone out to all users this release with no possibility for us to do an emergency rollback without pushing a new version of the extension or given you a way to opt out in any way until we made a new release with a fix.
To get early feedback from users willing to help us find bugs early. Obviously this didn't come up from testing with our pre-release users and are now only running across this from wider usage. |
|
How to pin? I apologise for my ton but when one wastes a whole morning, in a weekend with a critical deadline... |
You can change the version in the extension view via "Install Another Version":
Now if you want it to update when we push a new stable version, that's all you need to do. If you want to stay on that version, you can turn off automatic updates for the extension:
Otherwise you need to turn off automatic extension updates via the
Apology accepted. We realize hitting any bug is annoying and we obviously do what we can to avoid it; this is why there isn't anything the extension does that you couldn't do manually (e.g., run your test suite from the command-line instead of having VS Code do it). We always strive to make sure there's no lock-in specifically to make sure we are never a complete blocker for one's work or you feel trapped by the extension. |
|
VS Code version: Code - Insiders 1.85.0-insider (9aacac648821b5c9c1a7192ac9d44c50af6fe241, 2023-11-06T05:34:22.485Z) System Info
Extensions (40)
A/B Experiments |
|
Hello, thank you for the detailed logs and all the notes I really appreciate it. I am going out of office for the next 3 weeks and therefore will not be able to help in this time. I will loop in @karthiknadig in case you have outstanding questions to get by in the meantime. Additional, @karthiknadig do you know what this log is saying / if it might impact? |
github-actions
bot
added
the
info-needed
|
So, several of our projects don't have Python environments but it seems like the Python plugin tries to find the virtualenv anyway. I left that configuration in the example so it mirrored my actual project. Those are the Node errors that get thrown when it tries to find These are probably red herrings; unless they aren't and that's what's causing the entire issue. I think I've tried with a smaller workspace where every project has a Python interpreter and had the same issues though, so while it's a path to investigate, it may not bear fruit. |
github-actions
bot
removed
the
info-needed
|
realized now this isn't the problem- seeing other messages elsewhere which show it did run and this was just a warning. |
github-actions
bot
added
the
info-needed
|
New thought actually, @karthiknadig what do you think about the theory that in this multiroot workspace case the results are attempting to be parsed by the wrong adapter (like an adapter from a different workspace) instead of the one which it actually correlates to. Therefore it would error out all the other workspaces instead of just letting them wait for their response to be returned. Thinking |
|
That makes sense. This should get addressed when we use the per-run named-pipe server. |
|
Would you all mind reopening this? |
github-actions
bot
removed
the
info-needed
|
I have the exact same problem, let me know if I can provide some feedback |
|
update for those in this thread with symlink issues: I have put together a detailed problem report and proposed solution for symlinks. Please check it out here and contribute any thoughts you may have: #22658 |
github-actions
bot
added
the
info-needed
|
Is the symlink fix expected to fully resolve this or is that just a related fix? I think I'm still having this problem even if I open it from the non-symlinked path (which I've been doing because of all the symlink problems!). |
github-actions
bot
removed
the
info-needed
|
Hello! Symlink bug should be fixed and on vscode insiders! The release to vscode stable will be out by the end of the week. Please let me know if you try it on insiders or stable when it comes out and still doesn't work and I can investigate your specific issue further. @mrburrito, are you seeing the same error as before, I will circle back! |
github-actions
bot
added
the
info-needed
|
I'm no longer on the team that was having the issues. Let me try to get somebody to test it out and get back to you! Looking to see if I can reproduce on a different project as well. |
github-actions
bot
removed
the
info-needed
|
Thank you, appreciate it! |
wesm
pushed a commit
to posit-dev/positron
that referenced
this issue
Mar 28, 2024
…se 2023.16.0 Merge pull request #213 from posit-dev/merge/2023.16.0 Merge python extension release 2023.16.0 -------------------- Commit message for posit-dev/positron-python@cca4be0: Fix pyright issues -------------------- Commit message for posit-dev/positron-python@c3bd360: Merge branch 'main' into merge/2023.16.0 -------------------- Commit message for posit-dev/positron-python@bebadea: EnvironmentVariableScope now provided by vscode 1.82 -------------------- Commit message for posit-dev/positron-python@3e9d86b: Add back installation capability for ipykernel -------------------- Commit message for posit-dev/positron-python@6a7d49a: Merge commit '8c612511b99cb5ebc78153684de8fe595bd154dc' -------------------- Commit message for microsoft/vscode-python@8c61251: Update version for release candidate (microsoft/vscode-python#21919) -------------------- Commit message for microsoft/vscode-python@d9b9c88: Always prepend to PATH instead of replacing it (microsoft/vscode-python#21906) For microsoft/vscode-python#20822 microsoft/vscode-python#11039 Replacing as-is has its problems, for eg. pyenv asks their users to manipulate `PATH` in their init script: https://github.com/pyenv/pyenv#set-up-your-shell-environment-for-pyenv, which we could end up replacing.  Particularly for pyenv, it mean users not being able to find pyenv:  Prepending solves it for cases where initial PATH value is suffix of the final value:  But, in other cases, this means that we end up with the whole `PATH` thrice. This is because it prepends it twice: - Once in shell integration script - Once when creating a process So the final value could be: ``` PATH=<activated_full_path><activated_full_path><original_path> ``` where `<activated_full_path>` refers to value of `PATH` environment variable post activation. eg.  -------------------- Commit message for microsoft/vscode-python@7a9294c: Apply feedback for terminal activation prompt (microsoft/vscode-python#21905) For microsoft/vscode-python#21793  -------------------- Commit message for microsoft/vscode-python@44f5bf7: Set PS1 for conda environments in non-Windows when in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21902) For microsoft/vscode-python#20822  -------------------- Commit message for microsoft/vscode-python@7d25ceb: Remove finalized api proposals from package.json (microsoft/vscode-python#21900) Part of microsoft/vscode#191605 -------------------- Commit message for microsoft/vscode-python@31aa246: Also show env name for prefixed conda envs in terminal prompt (microsoft/vscode-python#21899) -------------------- Commit message for microsoft/vscode-python@941fcfa: Fixes from TPIs (microsoft/vscode-python#21896) Closes microsoft/vscode-python#21884 Closes microsoft/vscode-python#21889 -------------------- Commit message for microsoft/vscode-python@f255e02: Call out that env name may not show in terminal activation notification (microsoft/vscode-python#21897) Closes microsoft/vscode-python#21887 -------------------- Commit message for microsoft/vscode-python@782d5b1: Also show interpreter in status bar when a Python related output channel is opened (microsoft/vscode-python#21894) Closes microsoft/vscode-python#21890 -------------------- Commit message for microsoft/vscode-python@1204011: Activate environment when not using integrated terminal for debugging (microsoft/vscode-python#21880) For microsoft/vscode-python#4300 -------------------- Commit message for microsoft/vscode-python@98428cd: Apply custom env variables to terminal when in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21879) For microsoft/vscode-python#944 microsoft/vscode-python#20822 We only apply those env vars to terminal which are not in process env variables, hence remove custom env vars from process variables. -------------------- Commit message for microsoft/vscode-python@3fa5d4b: Support for Create Env command to re-create env for venv (microsoft/vscode-python#21829) Closes microsoft/vscode-python#21827 -------------------- Commit message for microsoft/vscode-python@30e26c2: Update proposed API for env collection (microsoft/vscode-python#21819) For microsoft/vscode-python#20822 Blocked on microsoft/vscode#171173 (comment) -------------------- Commit message for microsoft/vscode-python@15bb974: Do not filter using scheme when filtering environments (microsoft/vscode-python#21862) For microsoft/vscode-python#21825 On codespaces, it was leading to workspace environments not being displayed, which could mess up auto-selection. -------------------- Commit message for microsoft/vscode-python@cfbf1f3: remove usage of pytest CollectReport in rewrite (microsoft/vscode-python#21859) as per https://docs.pytest.org/en/7.1.x/reference/reference.html#collectreport, `CollectReport` is experimental and therefore it should not be in our extension. Fixes microsoft/vscode-python#21784 -------------------- Commit message for microsoft/vscode-python@0749b20: Show `Python: Clear Workspace interpreter` command regardless of whether a Python file is opened (microsoft/vscode-python#21858) Closes microsoft/vscode-python#21850 -------------------- Commit message for microsoft/vscode-python@021b362: Update VS Code engine (microsoft/vscode-python#21847) For microsoft/vscode-python#21831 -------------------- Commit message for microsoft/vscode-python@8407e9d: Wrap env collection workspace proposed APIs in `try...catch` block (microsoft/vscode-python#21846) Closes microsoft/vscode-python#21831 -------------------- Commit message for microsoft/vscode-python@c979455: Set workspaceFolder in debug config before substituting command variables (microsoft/vscode-python#21835) For microsoft/vscode-python#18482 -------------------- Commit message for microsoft/vscode-python@96ba735: fix data to string from buffer for output channel (microsoft/vscode-python#21821) fix microsoft/vscode-python#21820 -------------------- Commit message for microsoft/vscode-python@5140a8d: Apply API recommendations for Create Env API (microsoft/vscode-python#21804) Closes microsoft/vscode-python#21090 -------------------- Commit message for microsoft/vscode-python@0248fa8: fixing failing tests on CI (microsoft/vscode-python#21814) fixing microsoft/vscode-python#21813 -------------------- Commit message for microsoft/vscode-python@9c740b9: Show notification reaffirming Python extension still handles activation when in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21802) Closes microsoft/vscode-python#21793 Only show notification when terminal prompt does not already indicate that env is activated. -------------------- Commit message for microsoft/vscode-python@b447bf1: Feature branch testing overflow bug fix (microsoft/vscode-python#21812) This merges in two PRs that were reverted because of a bug introduced that caused subprocess overflow. reverted PRs: microsoft/vscode-python#21667, microsoft/vscode-python#21682 This now implements these two PRs allowing for absolute testIds and an execObservable for the subprocess. This PR also adds a bug fix and functional tests to ensure this doesn't happen again. Since this PR is large, all items in it have already been reviewed as they were merged into the feature branch. -------------------- Commit message for microsoft/vscode-python@bd749aa: Fix `service.test.ts` to stop disposing of all services (microsoft/vscode-python#21811) file `service.test.ts` was calling to dispose of all items related to the service container for clean up. This led to services in later tests failing since they were close already. Fixes here allow for new tests in the test adapter to be written. fix helps microsoft/vscode-python#21803 -------------------- Commit message for microsoft/vscode-python@385bb37: Add `language_server.jinja_usage` to `pylance.ts` (microsoft/vscode-python#21809) -------------------- Commit message for microsoft/vscode-python@71d6dab: Add one more property to load event (microsoft/vscode-python#21800) This PR adds app name to the editor_load telemetry event -------------------- Commit message for microsoft/vscode-python@ab8d3b2: Update VS Code engine (microsoft/vscode-python#21799) For microsoft/vscode-python#11039 -------------------- Commit message for microsoft/vscode-python@835eab5: Add setting to control severity of missing package diagnostic. (microsoft/vscode-python#21794) Closes microsoft/vscode-python#21792 -------------------- Commit message for microsoft/vscode-python@fbbf987: Use updated API to fetch scoped env collection (microsoft/vscode-python#21788) For microsoft/vscode#171173 microsoft/vscode-python#20822 To be merged tomorrow when latest insiders is released. Blocked on microsoft/vscode#189979. -------------------- Commit message for microsoft/vscode-python@0a2c285: Bump brettcannon/check-for-changed-files from 1.1.1 to 1.2.0 (microsoft/vscode-python#21772) Bumps [brettcannon/check-for-changed-files](https://github.com/brettcannon/check-for-changed-files) from 1.1.1 to 1.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/brettcannon/check-for-changed-files/releases">brettcannon/check-for-changed-files's releases</a>.</em></p> <blockquote> <h2>v1.2.0</h2> <h2>What's Changed</h2> <ul> <li>Add support for github tokens for private repos. by <a href="https://github.com/Marenz"><code>@Marenz</code></a> in <a href="https://redirect.github.com/brettcannon/check-for-changed-files/pull/83">brettcannon/check-for-changed-files#83</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Marenz"><code>@Marenz</code></a> made their first contribution in <a href="https://redirect.github.com/brettcannon/check-for-changed-files/pull/83">brettcannon/check-for-changed-files#83</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/brettcannon/check-for-changed-files/compare/v1...v1.2.0">https://github.com/brettcannon/check-for-changed-files/compare/v1...v1.2.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/brettcannon/check-for-changed-files/commit/4170644959a21843b31f1181f2a1761d65ef4791"><code>4170644</code></a> Add support for github tokens for private repos. (<a href="https://redirect.github.com/brettcannon/check-for-changed-files/issues/83">#83</a>)</li> <li><a href="https://github.com/brettcannon/check-for-changed-files/commit/294a99714e0d350b5083472a293d41bc91804e68"><code>294a997</code></a> Bump word-wrap from 1.2.3 to 1.2.4 (<a href="https://redirect.github.com/brettcannon/check-for-changed-files/issues/82">#82</a>)</li> <li>See full diff in <a href="https://github.com/brettcannon/check-for-changed-files/compare/v1.1.1...v1.2.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@9ac14b8: Update README.md for npm package (microsoft/vscode-python#21766) Fix indent for https://www.npmjs.com/package/@vscode/python-extension?activeTab=readme -------------------- Commit message for microsoft/vscode-python@3fed49f: Add Ruff to CI (microsoft/vscode-python#21739) Add Ruff to (lint > action.yml) CI #21738 -------------------- Commit message for microsoft/vscode-python@c490339: Update version of npm package (microsoft/vscode-python#21765) -------------------- Commit message for microsoft/vscode-python@8e0e59b: Remove optionalDependencies from API npm package and document to install vscode types separately (microsoft/vscode-python#21764) Closes It still leads to conflicts due to double installation of vscode types when testing through the cases, removing vscode types as dependencies altogether and documenting to install it separately instead. -------------------- Commit message for microsoft/vscode-python@cabdf39: Use `optionalDependencies` instead of `peerDependencies` for `@vscode/python-extension` npm package (microsoft/vscode-python#21763) Closes microsoft/vscode-python#21720 -------------------- Commit message for microsoft/vscode-python@dd20561: revert due to buffer overflow on subprocess (microsoft/vscode-python#21762) revert microsoft/vscode-python#21667 because it causes buffer overflow in the python testing subprocess when larger repos are used. Specifically seen on pytest discovery with >200 tests. Revert to align with the stable release and put in a fix next week. -------------------- Commit message for microsoft/vscode-python@40ff6e9: Remove private Jupyter APIs from public API types (microsoft/vscode-python#21761) For microsoft/vscode-jupyter#13986 -------------------- Commit message for microsoft/vscode-python@23353bb: Improvements to `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21751) -------------------- Commit message for microsoft/vscode-python@40bb62a: fix spelling for get-pip.py (microsoft/vscode-python#21752) fix spelling from get_pip to get-pip as advised. -------------------- Commit message for microsoft/vscode-python@f454515: Update release plan to document what to do with `main` during endgame week (microsoft/vscode-python#21743) -------------------- Commit message for microsoft/vscode-python@dff25d4: revert absolute test-ids (microsoft/vscode-python#21742) seeing a substantial error where test discovery is broken. Reverting this commit seems to be the temporary fix until I can diagnose the real problem. commit it is reverting: microsoft/vscode-python#21682 -------------------- Commit message for microsoft/vscode-python@ca4dfd4: update tests only on save with more files excluded (microsoft/vscode-python#21741) fixes microsoft/vscode-python#21014 and microsoft/vscode-python#21061 -------------------- Commit message for microsoft/vscode-python@84bbff9: add cwd for debugging (microsoft/vscode-python#21668) fixes microsoft/vscode-python#21648 (comment) -------------------- Commit message for microsoft/vscode-python@ef16727: Clean up smoke test requirement (microsoft/vscode-python#21729) Cleaning up smoke test dependency: See if all Github action test pass with removing the smoke test requirement file content. Checked one by one, and came to see removing all doesn't seem to have impact on the outcome of running smoke test.(Seems to have no difference in smoke test result outcome when ran with "Run and Debug" in VS Code with smoke-test option selected). Also got rid of below, after checking smoke test correctly passing after removal of smoke-test-requirement.txt content:  Resolve: microsoft/vscode-python#21496 -------------------- Commit message for microsoft/vscode-python@358635d: Remove old and unused API for Jupyter Ext (microsoft/vscode-python#21731) We have not used any of this API for a while now, hence its safe to remove these. Will be removing more soon. -------------------- Commit message for microsoft/vscode-python@8f3d60b: unittest discovery errors not displaying in test explorer (microsoft/vscode-python#21726) saw an issue where if discovery failed there was no notice in the test explorer for unittest. It was due to a different value for the new blank value for the payload tests. fixes microsoft/vscode-python#21725 and microsoft/vscode-python#21688 -------------------- Commit message for microsoft/vscode-python@a6a8cb1: Update main to next pre-release (microsoft/vscode-python#21728) -------------------- Commit message for microsoft/vscode-python@4ab510d: Update version for release candidate (microsoft/vscode-python#21727) -------------------- Commit message for microsoft/vscode-python@3e7118f: Update packages for Jedi and core python (microsoft/vscode-python#21710) -------------------- Commit message for microsoft/vscode-python@237f82b: Fix UUID and disposing to resolve race condition (microsoft/vscode-python#21667) fixes microsoft/vscode-python#21599 and microsoft/vscode-python#21507 -------------------- Commit message for microsoft/vscode-python@d9e368f: add area-repl to issue label (microsoft/vscode-python#21718) added area-repl as one of the issue label. -------------------- Commit message for microsoft/vscode-python@ceecdb0: Removing Jupyter Notebooks mentions from package.json (microsoft/vscode-python#21708) -------------------- Commit message for microsoft/vscode-python@11a9f1d: Remove unwanted Jupyter API (microsoft/vscode-python#21702) Fixes microsoft/vscode-jupyter#13986 -------------------- Commit message for microsoft/vscode-python@efcc3d7: Make test_ids relative to workspace path not root dir (microsoft/vscode-python#21682) makes sure all testIds that are returned to the extension are relative to the workspace (which will be the invocation directory) instead of to the root. This will stop testIds for not being recognized when using a config file or another parameter that changes the root directory during pytest. fixes microsoft/vscode-python#21640 and microsoft/vscode-python#21637 -------------------- Commit message for microsoft/vscode-python@06d62aa: Update homepage for Python API package (microsoft/vscode-python#21703) For microsoft/vscode-python#21631 -------------------- Commit message for microsoft/vscode-python@83107cc: Move "vscode" out of required dependencies for npm package (microsoft/vscode-python#21701) Closes microsoft/vscode-python#21684 -------------------- Commit message for microsoft/vscode-python@d673004: Convert JS-style typings to native TS in `@vscode/python-extension` (microsoft/vscode-python#21692) Closes microsoft/vscode-python#21690 -------------------- Commit message for microsoft/vscode-python@8b9bca1: Do not show "Select at workspace level" option if only one workspace folder is opened (microsoft/vscode-python#21689) Closes microsoft/vscode-python#21220 -------------------- Commit message for microsoft/vscode-python@f536b74: Edit issue-labels.yml, triage-info-needed.yml (microsoft/vscode-python#21685) Add Anthony to issue-labels.yml and triage-info-needed.yml -------------------- Commit message for microsoft/vscode-python@a42cb33: Add new telemetry property to GPDR (microsoft/vscode-python#21683) This property was added for tracking diagnostics we emit in Pylance. -------------------- Commit message for microsoft/vscode-python@6af959d: Dev Container Using MCR (microsoft/vscode-python#21675) Dev container rewrite using MCR. Pyenv for installing and managing python versions. Fish also installed as optional (able to view as shell option in codespaces). Also fixing conda error. Takes care of: microsoft/vscode-python#21591 rewrite from: microsoft/vscode-python#21435 to adhere to company policy. -------------------- Commit message for microsoft/vscode-python@73a0e9d: handle skip unittest at file without error (microsoft/vscode-python#21678) fixes microsoft/vscode-python#21653 -------------------- Commit message for microsoft/vscode-python@9bcb82d: Ensure `Run Python in dedicated terminal` uses `python.executeInFirDir` setting (microsoft/vscode-python#21681) -------------------- Commit message for microsoft/vscode-python@713007f: correct discovery on unittest skip at file level (microsoft/vscode-python#21665) given a file called skip_test_file_node.py that has `raise SkipTest(".....")` this should appear in the sidebar with no children. The bug is that currently it shows a "unittest" node that gives "loader" and other incorrect nodes below it. -------------------- Commit message for microsoft/vscode-python@be334bd: Do not resolve symbolic links in posix locator if they exceed the count limit (microsoft/vscode-python#21658) Closes microsoft/vscode-python#21310 Fixes interpreter discovery running forever for non-Windows OS -------------------- Commit message for microsoft/vscode-python@c256678: Prevent posix paths locator from crashing (microsoft/vscode-python#21657) For microsoft/vscode-python#21310 -------------------- Commit message for microsoft/vscode-python@81ae205: Bring back feature to Run Python file in dedicated terminal (microsoft/vscode-python#21656) Closes microsoft/vscode-python#21282 Closes microsoft/vscode-python#21420 Closes microsoft/vscode-python#21215 Reverts microsoft/vscode-python#21418 -------------------- Commit message for microsoft/vscode-python@c144200: Modify .eslintrc to turn off any errors for declaration files (microsoft/vscode-python#21652) For microsoft/vscode-python#21631 -------------------- Commit message for microsoft/vscode-python@f7125da: Use correct `tsconfig.json` when generating npm package (microsoft/vscode-python#21651) For microsoft/vscode-python#21631 - Unset `removeComment` as that leads to declarations without docstrings - Set to generate declarations - Use updated typescript which results in cleaner declaration files -------------------- Commit message for microsoft/vscode-python@2e8dc67: Add extra logging regarding interpreter discovery (microsoft/vscode-python#21639) For microsoft/vscode-python#21310 -------------------- Commit message for microsoft/vscode-python@fc1c391: Compare global storage data using only `key` (microsoft/vscode-python#21636) Closes microsoft/vscode-python#21635 by applying the same fix as done in microsoft/vscode-python#17627. Lead-authored-by: Kartik Raj <[email protected]> Co-authored-by: Daniel Imms <[email protected]> Co-authored-by: Luciana Abud <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Courtney Webster <[email protected]> Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Erik De Bonte <[email protected]> Co-authored-by: Rich Chiodo <[email protected]> Co-authored-by: Don Jayamanne <[email protected]> Co-authored-by: Anthony Kim <[email protected]> Co-authored-by: Pete Farland <[email protected]> Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: Eleanor Boyd <[email protected]> Signed-off-by: GitHub <[email protected]>
wesm
pushed a commit
to posit-dev/positron
that referenced
this issue
Mar 28, 2024
…se 2023.16.0 Merge pull request #213 from posit-dev/merge/2023.16.0 Merge python extension release 2023.16.0 -------------------- Commit message for posit-dev/positron-python@cca4be0: Fix pyright issues -------------------- Commit message for posit-dev/positron-python@c3bd360: Merge branch 'main' into merge/2023.16.0 -------------------- Commit message for posit-dev/positron-python@bebadea: EnvironmentVariableScope now provided by vscode 1.82 -------------------- Commit message for posit-dev/positron-python@3e9d86b: Add back installation capability for ipykernel -------------------- Commit message for posit-dev/positron-python@6a7d49a: Merge commit '8c612511b99cb5ebc78153684de8fe595bd154dc' -------------------- Commit message for microsoft/vscode-python@8c61251: Update version for release candidate (microsoft/vscode-python#21919) -------------------- Commit message for microsoft/vscode-python@d9b9c88: Always prepend to PATH instead of replacing it (microsoft/vscode-python#21906) For microsoft/vscode-python#20822 microsoft/vscode-python#11039 Replacing as-is has its problems, for eg. pyenv asks their users to manipulate `PATH` in their init script: https://github.com/pyenv/pyenv#set-up-your-shell-environment-for-pyenv, which we could end up replacing.  Particularly for pyenv, it mean users not being able to find pyenv:  Prepending solves it for cases where initial PATH value is suffix of the final value:  But, in other cases, this means that we end up with the whole `PATH` thrice. This is because it prepends it twice: - Once in shell integration script - Once when creating a process So the final value could be: ``` PATH=<activated_full_path><activated_full_path><original_path> ``` where `<activated_full_path>` refers to value of `PATH` environment variable post activation. eg.  -------------------- Commit message for microsoft/vscode-python@7a9294c: Apply feedback for terminal activation prompt (microsoft/vscode-python#21905) For microsoft/vscode-python#21793  -------------------- Commit message for microsoft/vscode-python@44f5bf7: Set PS1 for conda environments in non-Windows when in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21902) For microsoft/vscode-python#20822  -------------------- Commit message for microsoft/vscode-python@7d25ceb: Remove finalized api proposals from package.json (microsoft/vscode-python#21900) Part of microsoft/vscode#191605 -------------------- Commit message for microsoft/vscode-python@31aa246: Also show env name for prefixed conda envs in terminal prompt (microsoft/vscode-python#21899) -------------------- Commit message for microsoft/vscode-python@941fcfa: Fixes from TPIs (microsoft/vscode-python#21896) Closes microsoft/vscode-python#21884 Closes microsoft/vscode-python#21889 -------------------- Commit message for microsoft/vscode-python@f255e02: Call out that env name may not show in terminal activation notification (microsoft/vscode-python#21897) Closes microsoft/vscode-python#21887 -------------------- Commit message for microsoft/vscode-python@782d5b1: Also show interpreter in status bar when a Python related output channel is opened (microsoft/vscode-python#21894) Closes microsoft/vscode-python#21890 -------------------- Commit message for microsoft/vscode-python@1204011: Activate environment when not using integrated terminal for debugging (microsoft/vscode-python#21880) For microsoft/vscode-python#4300 -------------------- Commit message for microsoft/vscode-python@98428cd: Apply custom env variables to terminal when in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21879) For microsoft/vscode-python#944 microsoft/vscode-python#20822 We only apply those env vars to terminal which are not in process env variables, hence remove custom env vars from process variables. -------------------- Commit message for microsoft/vscode-python@3fa5d4b: Support for Create Env command to re-create env for venv (microsoft/vscode-python#21829) Closes microsoft/vscode-python#21827 -------------------- Commit message for microsoft/vscode-python@30e26c2: Update proposed API for env collection (microsoft/vscode-python#21819) For microsoft/vscode-python#20822 Blocked on microsoft/vscode#171173 (comment) -------------------- Commit message for microsoft/vscode-python@15bb974: Do not filter using scheme when filtering environments (microsoft/vscode-python#21862) For microsoft/vscode-python#21825 On codespaces, it was leading to workspace environments not being displayed, which could mess up auto-selection. -------------------- Commit message for microsoft/vscode-python@cfbf1f3: remove usage of pytest CollectReport in rewrite (microsoft/vscode-python#21859) as per https://docs.pytest.org/en/7.1.x/reference/reference.html#collectreport, `CollectReport` is experimental and therefore it should not be in our extension. Fixes microsoft/vscode-python#21784 -------------------- Commit message for microsoft/vscode-python@0749b20: Show `Python: Clear Workspace interpreter` command regardless of whether a Python file is opened (microsoft/vscode-python#21858) Closes microsoft/vscode-python#21850 -------------------- Commit message for microsoft/vscode-python@021b362: Update VS Code engine (microsoft/vscode-python#21847) For microsoft/vscode-python#21831 -------------------- Commit message for microsoft/vscode-python@8407e9d: Wrap env collection workspace proposed APIs in `try...catch` block (microsoft/vscode-python#21846) Closes microsoft/vscode-python#21831 -------------------- Commit message for microsoft/vscode-python@c979455: Set workspaceFolder in debug config before substituting command variables (microsoft/vscode-python#21835) For microsoft/vscode-python#18482 -------------------- Commit message for microsoft/vscode-python@96ba735: fix data to string from buffer for output channel (microsoft/vscode-python#21821) fix microsoft/vscode-python#21820 -------------------- Commit message for microsoft/vscode-python@5140a8d: Apply API recommendations for Create Env API (microsoft/vscode-python#21804) Closes microsoft/vscode-python#21090 -------------------- Commit message for microsoft/vscode-python@0248fa8: fixing failing tests on CI (microsoft/vscode-python#21814) fixing microsoft/vscode-python#21813 -------------------- Commit message for microsoft/vscode-python@9c740b9: Show notification reaffirming Python extension still handles activation when in `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21802) Closes microsoft/vscode-python#21793 Only show notification when terminal prompt does not already indicate that env is activated. -------------------- Commit message for microsoft/vscode-python@b447bf1: Feature branch testing overflow bug fix (microsoft/vscode-python#21812) This merges in two PRs that were reverted because of a bug introduced that caused subprocess overflow. reverted PRs: microsoft/vscode-python#21667, microsoft/vscode-python#21682 This now implements these two PRs allowing for absolute testIds and an execObservable for the subprocess. This PR also adds a bug fix and functional tests to ensure this doesn't happen again. Since this PR is large, all items in it have already been reviewed as they were merged into the feature branch. -------------------- Commit message for microsoft/vscode-python@bd749aa: Fix `service.test.ts` to stop disposing of all services (microsoft/vscode-python#21811) file `service.test.ts` was calling to dispose of all items related to the service container for clean up. This led to services in later tests failing since they were close already. Fixes here allow for new tests in the test adapter to be written. fix helps microsoft/vscode-python#21803 -------------------- Commit message for microsoft/vscode-python@385bb37: Add `language_server.jinja_usage` to `pylance.ts` (microsoft/vscode-python#21809) -------------------- Commit message for microsoft/vscode-python@71d6dab: Add one more property to load event (microsoft/vscode-python#21800) This PR adds app name to the editor_load telemetry event -------------------- Commit message for microsoft/vscode-python@ab8d3b2: Update VS Code engine (microsoft/vscode-python#21799) For microsoft/vscode-python#11039 -------------------- Commit message for microsoft/vscode-python@835eab5: Add setting to control severity of missing package diagnostic. (microsoft/vscode-python#21794) Closes microsoft/vscode-python#21792 -------------------- Commit message for microsoft/vscode-python@fbbf987: Use updated API to fetch scoped env collection (microsoft/vscode-python#21788) For microsoft/vscode#171173 microsoft/vscode-python#20822 To be merged tomorrow when latest insiders is released. Blocked on microsoft/vscode#189979. -------------------- Commit message for microsoft/vscode-python@0a2c285: Bump brettcannon/check-for-changed-files from 1.1.1 to 1.2.0 (microsoft/vscode-python#21772) Bumps [brettcannon/check-for-changed-files](https://github.com/brettcannon/check-for-changed-files) from 1.1.1 to 1.2.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/brettcannon/check-for-changed-files/releases">brettcannon/check-for-changed-files's releases</a>.</em></p> <blockquote> <h2>v1.2.0</h2> <h2>What's Changed</h2> <ul> <li>Add support for github tokens for private repos. by <a href="https://github.com/Marenz"><code>@Marenz</code></a> in <a href="https://redirect.github.com/brettcannon/check-for-changed-files/pull/83">brettcannon/check-for-changed-files#83</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Marenz"><code>@Marenz</code></a> made their first contribution in <a href="https://redirect.github.com/brettcannon/check-for-changed-files/pull/83">brettcannon/check-for-changed-files#83</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/brettcannon/check-for-changed-files/compare/v1...v1.2.0">https://github.com/brettcannon/check-for-changed-files/compare/v1...v1.2.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/brettcannon/check-for-changed-files/commit/4170644959a21843b31f1181f2a1761d65ef4791"><code>4170644</code></a> Add support for github tokens for private repos. (<a href="https://redirect.github.com/brettcannon/check-for-changed-files/issues/83">#83</a>)</li> <li><a href="https://github.com/brettcannon/check-for-changed-files/commit/294a99714e0d350b5083472a293d41bc91804e68"><code>294a997</code></a> Bump word-wrap from 1.2.3 to 1.2.4 (<a href="https://redirect.github.com/brettcannon/check-for-changed-files/issues/82">#82</a>)</li> <li>See full diff in <a href="https://github.com/brettcannon/check-for-changed-files/compare/v1.1.1...v1.2.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> -------------------- Commit message for microsoft/vscode-python@9ac14b8: Update README.md for npm package (microsoft/vscode-python#21766) Fix indent for https://www.npmjs.com/package/@vscode/python-extension?activeTab=readme -------------------- Commit message for microsoft/vscode-python@3fed49f: Add Ruff to CI (microsoft/vscode-python#21739) Add Ruff to (lint > action.yml) CI #21738 -------------------- Commit message for microsoft/vscode-python@c490339: Update version of npm package (microsoft/vscode-python#21765) -------------------- Commit message for microsoft/vscode-python@8e0e59b: Remove optionalDependencies from API npm package and document to install vscode types separately (microsoft/vscode-python#21764) Closes It still leads to conflicts due to double installation of vscode types when testing through the cases, removing vscode types as dependencies altogether and documenting to install it separately instead. -------------------- Commit message for microsoft/vscode-python@cabdf39: Use `optionalDependencies` instead of `peerDependencies` for `@vscode/python-extension` npm package (microsoft/vscode-python#21763) Closes microsoft/vscode-python#21720 -------------------- Commit message for microsoft/vscode-python@dd20561: revert due to buffer overflow on subprocess (microsoft/vscode-python#21762) revert microsoft/vscode-python#21667 because it causes buffer overflow in the python testing subprocess when larger repos are used. Specifically seen on pytest discovery with >200 tests. Revert to align with the stable release and put in a fix next week. -------------------- Commit message for microsoft/vscode-python@40ff6e9: Remove private Jupyter APIs from public API types (microsoft/vscode-python#21761) For microsoft/vscode-jupyter#13986 -------------------- Commit message for microsoft/vscode-python@23353bb: Improvements to `pythonTerminalEnvVarActivation` experiment (microsoft/vscode-python#21751) -------------------- Commit message for microsoft/vscode-python@40bb62a: fix spelling for get-pip.py (microsoft/vscode-python#21752) fix spelling from get_pip to get-pip as advised. -------------------- Commit message for microsoft/vscode-python@f454515: Update release plan to document what to do with `main` during endgame week (microsoft/vscode-python#21743) -------------------- Commit message for microsoft/vscode-python@dff25d4: revert absolute test-ids (microsoft/vscode-python#21742) seeing a substantial error where test discovery is broken. Reverting this commit seems to be the temporary fix until I can diagnose the real problem. commit it is reverting: microsoft/vscode-python#21682 -------------------- Commit message for microsoft/vscode-python@ca4dfd4: update tests only on save with more files excluded (microsoft/vscode-python#21741) fixes microsoft/vscode-python#21014 and microsoft/vscode-python#21061 -------------------- Commit message for microsoft/vscode-python@84bbff9: add cwd for debugging (microsoft/vscode-python#21668) fixes microsoft/vscode-python#21648 (comment) -------------------- Commit message for microsoft/vscode-python@ef16727: Clean up smoke test requirement (microsoft/vscode-python#21729) Cleaning up smoke test dependency: See if all Github action test pass with removing the smoke test requirement file content. Checked one by one, and came to see removing all doesn't seem to have impact on the outcome of running smoke test.(Seems to have no difference in smoke test result outcome when ran with "Run and Debug" in VS Code with smoke-test option selected). Also got rid of below, after checking smoke test correctly passing after removal of smoke-test-requirement.txt content:  Resolve: microsoft/vscode-python#21496 -------------------- Commit message for microsoft/vscode-python@358635d: Remove old and unused API for Jupyter Ext (microsoft/vscode-python#21731) We have not used any of this API for a while now, hence its safe to remove these. Will be removing more soon. -------------------- Commit message for microsoft/vscode-python@8f3d60b: unittest discovery errors not displaying in test explorer (microsoft/vscode-python#21726) saw an issue where if discovery failed there was no notice in the test explorer for unittest. It was due to a different value for the new blank value for the payload tests. fixes microsoft/vscode-python#21725 and microsoft/vscode-python#21688 -------------------- Commit message for microsoft/vscode-python@a6a8cb1: Update main to next pre-release (microsoft/vscode-python#21728) -------------------- Commit message for microsoft/vscode-python@4ab510d: Update version for release candidate (microsoft/vscode-python#21727) -------------------- Commit message for microsoft/vscode-python@3e7118f: Update packages for Jedi and core python (microsoft/vscode-python#21710) -------------------- Commit message for microsoft/vscode-python@237f82b: Fix UUID and disposing to resolve race condition (microsoft/vscode-python#21667) fixes microsoft/vscode-python#21599 and microsoft/vscode-python#21507 -------------------- Commit message for microsoft/vscode-python@d9e368f: add area-repl to issue label (microsoft/vscode-python#21718) added area-repl as one of the issue label. -------------------- Commit message for microsoft/vscode-python@ceecdb0: Removing Jupyter Notebooks mentions from package.json (microsoft/vscode-python#21708) -------------------- Commit message for microsoft/vscode-python@11a9f1d: Remove unwanted Jupyter API (microsoft/vscode-python#21702) Fixes microsoft/vscode-jupyter#13986 -------------------- Commit message for microsoft/vscode-python@efcc3d7: Make test_ids relative to workspace path not root dir (microsoft/vscode-python#21682) makes sure all testIds that are returned to the extension are relative to the workspace (which will be the invocation directory) instead of to the root. This will stop testIds for not being recognized when using a config file or another parameter that changes the root directory during pytest. fixes microsoft/vscode-python#21640 and microsoft/vscode-python#21637 -------------------- Commit message for microsoft/vscode-python@06d62aa: Update homepage for Python API package (microsoft/vscode-python#21703) For microsoft/vscode-python#21631 -------------------- Commit message for microsoft/vscode-python@83107cc: Move "vscode" out of required dependencies for npm package (microsoft/vscode-python#21701) Closes microsoft/vscode-python#21684 -------------------- Commit message for microsoft/vscode-python@d673004: Convert JS-style typings to native TS in `@vscode/python-extension` (microsoft/vscode-python#21692) Closes microsoft/vscode-python#21690 -------------------- Commit message for microsoft/vscode-python@8b9bca1: Do not show "Select at workspace level" option if only one workspace folder is opened (microsoft/vscode-python#21689) Closes microsoft/vscode-python#21220 -------------------- Commit message for microsoft/vscode-python@f536b74: Edit issue-labels.yml, triage-info-needed.yml (microsoft/vscode-python#21685) Add Anthony to issue-labels.yml and triage-info-needed.yml -------------------- Commit message for microsoft/vscode-python@a42cb33: Add new telemetry property to GPDR (microsoft/vscode-python#21683) This property was added for tracking diagnostics we emit in Pylance. -------------------- Commit message for microsoft/vscode-python@6af959d: Dev Container Using MCR (microsoft/vscode-python#21675) Dev container rewrite using MCR. Pyenv for installing and managing python versions. Fish also installed as optional (able to view as shell option in codespaces). Also fixing conda error. Takes care of: microsoft/vscode-python#21591 rewrite from: microsoft/vscode-python#21435 to adhere to company policy. -------------------- Commit message for microsoft/vscode-python@73a0e9d: handle skip unittest at file without error (microsoft/vscode-python#21678) fixes microsoft/vscode-python#21653 -------------------- Commit message for microsoft/vscode-python@9bcb82d: Ensure `Run Python in dedicated terminal` uses `python.executeInFirDir` setting (microsoft/vscode-python#21681) -------------------- Commit message for microsoft/vscode-python@713007f: correct discovery on unittest skip at file level (microsoft/vscode-python#21665) given a file called skip_test_file_node.py that has `raise SkipTest(".....")` this should appear in the sidebar with no children. The bug is that currently it shows a "unittest" node that gives "loader" and other incorrect nodes below it. -------------------- Commit message for microsoft/vscode-python@be334bd: Do not resolve symbolic links in posix locator if they exceed the count limit (microsoft/vscode-python#21658) Closes microsoft/vscode-python#21310 Fixes interpreter discovery running forever for non-Windows OS -------------------- Commit message for microsoft/vscode-python@c256678: Prevent posix paths locator from crashing (microsoft/vscode-python#21657) For microsoft/vscode-python#21310 -------------------- Commit message for microsoft/vscode-python@81ae205: Bring back feature to Run Python file in dedicated terminal (microsoft/vscode-python#21656) Closes microsoft/vscode-python#21282 Closes microsoft/vscode-python#21420 Closes microsoft/vscode-python#21215 Reverts microsoft/vscode-python#21418 -------------------- Commit message for microsoft/vscode-python@c144200: Modify .eslintrc to turn off any errors for declaration files (microsoft/vscode-python#21652) For microsoft/vscode-python#21631 -------------------- Commit message for microsoft/vscode-python@f7125da: Use correct `tsconfig.json` when generating npm package (microsoft/vscode-python#21651) For microsoft/vscode-python#21631 - Unset `removeComment` as that leads to declarations without docstrings - Set to generate declarations - Use updated typescript which results in cleaner declaration files -------------------- Commit message for microsoft/vscode-python@2e8dc67: Add extra logging regarding interpreter discovery (microsoft/vscode-python#21639) For microsoft/vscode-python#21310 -------------------- Commit message for microsoft/vscode-python@fc1c391: Compare global storage data using only `key` (microsoft/vscode-python#21636) Closes microsoft/vscode-python#21635 by applying the same fix as done in microsoft/vscode-python#17627. Lead-authored-by: Kartik Raj <[email protected]> Co-authored-by: Daniel Imms <[email protected]> Co-authored-by: Luciana Abud <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Courtney Webster <[email protected]> Co-authored-by: Brett Cannon <[email protected]> Co-authored-by: Erik De Bonte <[email protected]> Co-authored-by: Rich Chiodo <[email protected]> Co-authored-by: Don Jayamanne <[email protected]> Co-authored-by: Anthony Kim <[email protected]> Co-authored-by: Pete Farland <[email protected]> Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: Eleanor Boyd <[email protected]> Signed-off-by: GitHub <[email protected]>
|
Sorry for hijacking but #22018 is still not working for me and I can comment there anymore. |
|
@alanwilter I have re-opened the issue so we can discuss there- thanks |
|
Also closing this issue since we dont have the repro anymore but please create another issue / follow up on #22018 about symlinks so we can discuss any ongoing problems |
github-actions
bot
added
the
info-needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Type: Bug
Behaviour
It looks like test discovery was updated in the most recent Python release and it now breaks for my multi-root, multi-venv project.
When I run discovery, I see a stream of log messages about running the pytest commands and then a lot of messages like:
Once the refresh completes, I'll see only one, sometimes two or my test packages int he explorer and nothing else.
It looks to me like you may have changed how tests are discovered and handled by the new test server (experiment is enabled) and the discovery processes are not communicating back to the thread that's expecting them? Or maybe only the UUID from the last spawned process is tracked so that's the only one that gets discovered?
Expected vs. Actual
Expected: All of my tests to be discovered, displayed, and runnable from the test explorer.
Actual: Only tests from one module show up in test explorer.
Steps to reproduce:
<project>/.venvandpython.defaultInterpreterPath: "${workspaceFolder}/.venv/bin/python.Diagnostic data
python.languageServersetting: DefaultPythonoutput included in separate comment. Issue body too long.Extension version: 2023.12.0
VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.19044
Modes:
Remote OS version: Linux x64 3.10.0-1160.88.1.el7.x86_64 (test discovery running on this remote)
Remote OS version: Linux x64 4.18.0-425.19.2.el8_7.x86_64
System Info
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
A/B Experiments
The text was updated successfully, but these errors were encountered: