Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automation to automatically assigned milestones to issues closed during iteration #21935

Open
karrtikr opened this issue Sep 6, 2023 · 1 comment
Assignees
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@karrtikr
Copy link

karrtikr commented Sep 6, 2023

Ideally we only want to add milestones for issues which have an associated PR.

Together with #21934, this should make sure that an issue fixed is always verified.

@karrtikr karrtikr added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-internal Label for non-user facing issues needs PR Ready to be worked on labels Sep 6, 2023
@karrtikr
Copy link
Author

karrtikr commented Sep 6, 2023

@lramos15 We found something similar in https://github.com/microsoft/vscode-github-triage-actions/blob/stable/release-pipeline/index.ts but it also assumes the concept of "unreleased" labels, which we don't have.

Also it seems like https://github.com/microsoft/vscode-github-triage-actions/blob/71a4da6d2999defd04415ec9924c0579ad26ac90/release-pipeline/ReleasePipeline.ts#L81 calls into "issue.getClosingInfo()" which assumes we're working on vscode repository:

https://github.com/microsoft/vscode-github-triage-actions/blob/71a4da6d2999defd04415ec9924c0579ad26ac90/api/octokit.ts#L446-L461

Can you help with how to modify it to work with this repository? What we want to do is add the current milestone only if an issue is closed via a PR.

@lramos15 lramos15 self-assigned this Sep 12, 2023
@lramos15 lramos15 added this to the October 2023 milestone Sep 12, 2023
@karrtikr karrtikr modified the milestones: October 2023, November 2023 Oct 23, 2023
@lramos15 lramos15 modified the milestones: November 2023, December 2023 Nov 22, 2023
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
@eleanorjboyd eleanorjboyd assigned bhavyaus and unassigned lramos15 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-internal Label for non-user facing issues debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

4 participants