-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try avoid putting run commands into shell history #21998
Comments
Related issues: #7041 microsoft/vscode#85887 #9316 microsoft/vscode#85887 microsoft/vscode#87779 This is less of a problem now that we don't send activation commands in terminal, only when executing or debugging a file, which is maybe okay to put in shell history. microsoft/vscode#87779 hints that debugging is maybe solved now? |
Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue. |
Ideally the extension shouldn't be adding anything to history imo. |
Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue. |
I think this would essentially be fixed by adding a single space in front of some of the sendText activation commands. |
@Tyriar For debugging, the DAP client in VSCODE has to do this. Debugger just does a |
@karthiknadig if you put a space in front of the command you request, some shells will not add it to history |
@Tyriar This feels like VS Code should handle it at least for debugger scenarios. Then it would be something that is controlled by a setting in VS Code, than something that every DAP server has to implement. |
@karthiknadig perhaps, not sure it's been brought up with the debugger folks. The main example this was issue was specifically about the activate command which is still an option I believe |
For now, but may very well go away once terminal activation is solid enough to launch to a 100% of stable. |
A user in microsoft/vscode#192943 (comment) is using profile environments to try workaround source and run commands being added to shell history, leading to more problems:
Shells have various ways of avoiding adding entries into history. For example in bash you can add a space to the start of the command to have it not enter history. There are also some
HIST*
variables that define how history behaviors which are worth a read.The text was updated successfully, but these errors were encountered: