Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to named pipes for testing communication #22177

Closed
eleanorjboyd opened this issue Oct 9, 2023 · 2 comments · Fixed by #22390
Closed

switch to named pipes for testing communication #22177

eleanorjboyd opened this issue Oct 9, 2023 · 2 comments · Fixed by #22390
Assignees
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on

Comments

@eleanorjboyd
Copy link
Member

Right now all the ports used for tests are just numbered ports. These should be switched to named ports. There are two ports, the one that receives data and the one that sends test ids during run.

@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. area-testing labels Oct 9, 2023
@eleanorjboyd eleanorjboyd self-assigned this Oct 9, 2023
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 9, 2023
@karthiknadig karthiknadig changed the title switch to named ports for testing communication switch to named piles for testing communication Nov 27, 2023
@eleanorjboyd eleanorjboyd changed the title switch to named piles for testing communication switch to named pipes for testing communication Dec 1, 2023
@luabud luabud added needs PR Ready to be worked on and removed triage-needed Needs assignment to the proper sub-team labels Dec 14, 2023
@eleanorjboyd
Copy link
Member Author

#22170, is waiting on this issue as the changes to named pipes in the environment variables will change the values we are testing

@eleanorjboyd
Copy link
Member Author

#20662, will be resolved as well with this issue and switching to pipes removed the use of the server class in total.

karthiknadig added a commit that referenced this issue Apr 16, 2024
Resolves #22177.
Switches to using named pipes as communication between extension and
test run subprocesses.

---------

Co-authored-by: eleanorjboyd <[email protected]>
anthonykim1 pushed a commit to anthonykim1/vscode-python that referenced this issue May 10, 2024
Resolves microsoft#22177.
Switches to using named pipes as communication between extension and
test run subprocesses.

---------

Co-authored-by: eleanorjboyd <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this issue May 10, 2024
…python#22390)

Resolves microsoft/vscode-python#22177.
Switches to using named pipes as communication between extension and
test run subprocesses.

---------

Co-authored-by: eleanorjboyd <[email protected]>
seeM pushed a commit to posit-dev/positron that referenced this issue May 12, 2024
…python#22390)

Resolves microsoft/vscode-python#22177.
Switches to using named pipes as communication between extension and
test run subprocesses.

---------

Co-authored-by: eleanorjboyd <[email protected]>
wesm pushed a commit to posit-dev/positron that referenced this issue May 13, 2024
…python#22390)

Resolves microsoft/vscode-python#22177.
Switches to using named pipes as communication between extension and
test run subprocesses.

---------

Co-authored-by: eleanorjboyd <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing debt Covers everything internal: CI, testing, refactoring of the codebase, etc. needs PR Ready to be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants