Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont automatically inject PYTHONSTARTUP script #24345

Closed
anthonykim1 opened this issue Oct 28, 2024 · 0 comments · Fixed by #24346
Closed

Dont automatically inject PYTHONSTARTUP script #24345

anthonykim1 opened this issue Oct 28, 2024 · 0 comments · Fixed by #24346
Assignees
@anthonykim1
Labels
area-repl bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team

Comments

@anthonykim1
Copy link

Before #24141 we should make sure we completely make the decision of turning off/on shell integration for Python terminal REPL by looking at the setting.

Should make sure env: {} removing the default always true from previous
@anthonykim1 anthonykim1 added area-repl bug Issue identified by VS Code Team member as probable bug labels Oct 28, 2024
@anthonykim1 anthonykim1 self-assigned this Oct 28, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 28, 2024
@anthonykim1 anthonykim1 mentioned this issue Oct 28, 2024
Merged
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this issue Nov 4, 2024
@anthonykim1
dont automatically inject PYTHONSTARTUP (microsoft#24346)
aa15d83 
Resolves microsoft#24345 and
microsoft#24290 and
microsoft#24105
remove automatic injection from before so only thing that allows shell
integration to user for Python terminal REPL is the setting itself.
@anthonykim1 anthonykim1 mentioned this issue Nov 4, 2024
Merged
eleanorjboyd pushed a commit that referenced this issue Nov 6, 2024
@anthonykim1
Cherry pick dont automatically inject PYTHONSTARTUP (#24346) (#24386)
2769390 
Resolves #24345 and
#24290 and
#24105 remove automatic
injection from before so only thing that allows shell integration to
user for Python terminal REPL is the setting itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-repl bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dont automatically inject PYTHONSTARTUP anthonykim1/vscode-python
1 participant
@anthonykim1