Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show file pattern prompt for pytest #5732

Closed
karthiknadig opened this issue May 22, 2019 · 5 comments
Closed

Show file pattern prompt for pytest #5732

karthiknadig opened this issue May 22, 2019 · 5 comments
Labels
area-testing feature-request Request for new features or functionality

Comments

@karthiknadig
Copy link
Member

Environment data

  • VS Code version: 1.34.0
  • Extension version (available under the Extensions sidebar): 2019.6.16302-dev
  • OS and version: windows
  • Python version (& distribution if applicable, e.g. Anaconda): 3.7
  • Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A
  • Relevant/affected Python packages and their versions: pytest

Expected behaviour

Should show this prompt for pytest
image

Actual behaviour

Does not show prompt to select file pattern for pytest

Steps to reproduce:

  1. Follow prompts for Python: Configure Tests.
  2. Select pytest (does not get file pattern prompt)
  3. Select unittest (you will see file pattern prompt)
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label May 22, 2019
@DonJayamanne DonJayamanne added area-testing needs decision feature-request Request for new features or functionality labels May 22, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label May 22, 2019
@luabud
Copy link
Member

luabud commented Jul 2, 2019

we could prompt this if they don't have a pytest.ini file

@github-actions github-actions bot removed the needs PR label Aug 9, 2022
@karrtikr karrtikr added the needs PR Ready to be worked on label Aug 9, 2022
@eleanorjboyd
Copy link
Member

this flow would be impacted by: #21845

@karthiknadig
Copy link
Member Author

I don't think we are doing this given the different format we use to run tests now.

@github-actions github-actions bot removed the needs PR Ready to be worked on label Oct 30, 2023
@eleanorjboyd
Copy link
Member

We will be making changes to the setup flow as we switch to using distinct configs for run, discovery, and debug so changes there will also impact how this looks

@karthiknadig
Copy link
Member Author

Remember we decided that we are not going to support "**" in the pytest args as pytest itself does not give us an API for it. unittest has the pattern API for this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants