Skip to content

Commit

Permalink
Rename to editor group
Browse files Browse the repository at this point in the history
  • Loading branch information
osortega committed Nov 21, 2024
1 parent 2f88b4b commit 17cf79e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions src/vs/editor/common/config/editorOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1658,7 +1658,7 @@ export interface IEditorFindOptions {
/**
* Controls how the find widget search history should be stored
*/
findSearchHistory?: 'never' | 'workspace' | 'editor';
findSearchHistory?: 'never' | 'workspace' | 'editorGroup';
}

/**
Expand Down Expand Up @@ -1726,12 +1726,12 @@ class EditorFind extends BaseEditorOption<EditorOption.find, IEditorFindOptions,
},
'editor.find.findSearchHistory': {
type: 'string',
enum: ['never', 'workspace', 'editor'],
enum: ['never', 'workspace', 'editorGroup'],
default: defaults.findSearchHistory,
enumDescriptions: [
nls.localize('editor.find.findSearchHistory.never', 'Do not store search history from the find widget.'),
nls.localize('editor.find.findSearchHistory.workspace', 'Store search history across the active workspace'),
nls.localize('editor.find.findSearchHistory.editor', 'Store the search history per editor instance'),
nls.localize('editor.find.findSearchHistory.editorGroup', 'Store the search history per editor group'),
],
description: nls.localize('find.findSearchHistory', "Controls how the find widget search history should be stored")
}
Expand All @@ -1755,7 +1755,7 @@ class EditorFind extends BaseEditorOption<EditorOption.find, IEditorFindOptions,
globalFindClipboard: boolean(input.globalFindClipboard, this.defaultValue.globalFindClipboard),
addExtraSpaceOnTop: boolean(input.addExtraSpaceOnTop, this.defaultValue.addExtraSpaceOnTop),
loop: boolean(input.loop, this.defaultValue.loop),
findSearchHistory: stringSet<'never' | 'workspace' | 'editor'>(input.findSearchHistory, this.defaultValue.findSearchHistory, ['never', 'workspace', 'editor']),
findSearchHistory: stringSet<'never' | 'workspace' | 'editorGroup'>(input.findSearchHistory, this.defaultValue.findSearchHistory, ['never', 'workspace', 'editorGroup']),
};
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/vs/editor/contrib/find/browser/findWidget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export class FindWidget extends Widget implements IOverlayWidget, IVerticalSashL
const findSearchHistoryConfig = this._codeEditor.getOption(EditorOption.find).findSearchHistory;
this._findWidgetSearchHistory = new FindWidgetSearchHistory(
this._storageService,
findSearchHistoryConfig === 'editor' ? this._codeEditor : undefined
findSearchHistoryConfig === 'editorGroup' ? this._codeEditor : undefined
);

this._ctrlEnterReplaceAllWarningPrompted = !!storageService.getBoolean(ctrlEnterReplaceAllWarningPromptedKey, StorageScope.PROFILE);
Expand Down
2 changes: 1 addition & 1 deletion src/vs/monaco.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4064,7 +4064,7 @@ declare namespace monaco.editor {
/**
* Controls how the find widget search history should be stored
*/
findSearchHistory?: 'never' | 'workspace' | 'editor';
findSearchHistory?: 'never' | 'workspace' | 'editorGroup';
}

export type GoToLocationValues = 'peek' | 'gotoAndPeek' | 'goto';
Expand Down

0 comments on commit 17cf79e

Please sign in to comment.