Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml highlighting/textmate recognises some integers as strings (or vice versa?) #143368

Closed
pedroterzero opened this issue Feb 18, 2022 · 2 comments
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@pedroterzero
Copy link

Does this issue occur when all extensions are disabled?: Yes

Version: 1.64.2
Commit: f80445acd5a3dadef24aa209168452a3d97cc326
Date: 2022-02-09T22:02:29.527Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.13.0-28-generic snap

OS is Ubuntu 20.04

Description:

Some integers (or strings?) are treated differently even though they look the same to me.

In each comment I've specified what the scope inspector reports the scope as.

This is what it ends up looking like for me:
image

I'd expect them all to be the same; so either they should all be integers or they should all be unquoted strings.

Test case:

test:
  - test: 01 # constant.numeric.integer.yaml
  - test: 02 # constant.numeric.integer.yaml
  - test: 03 # constant.numeric.integer.yaml
  - test: 04 # constant.numeric.integer.yaml
  - test: 05 # constant.numeric.integer.yaml
  - test: 06 # constant.numeric.integer.yaml
  - test: 07 # constant.numeric.integer.yaml
  - test: 08 # string.unquoted.plain.out.yaml
  - test: 09 # string.unquoted.plain.out.yaml
  - test: 10 # constant.numeric.integer.yaml

Steps to Reproduce:

  1. Create a test file, test.yml with the contents from the test case
@alexr00
Copy link
Member

alexr00 commented Feb 23, 2022

Thank you for the detailed issue! I have moved it to the upstream repo that we get our yaml syntax highlighting grammar from: textmate/yaml.tmbundle#39

@alexr00 alexr00 closed this as completed Feb 23, 2022
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels Feb 23, 2022
@pedroterzero
Copy link
Author

Thank you for the detailed issue! I have moved it to the upstream repo that we get our yaml syntax highlighting grammar from: textmate/yaml.tmbundle#39

You're welcome, hopefully it can be resolved! Although that particular repo seems like a bit of a bug graveyard. Fingers crossed ;)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

3 participants