Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: Breadcrumbs not recognizing HTML5 optional tags #184129

Closed
920hime opened this issue Jun 2, 2023 · 9 comments
Closed

HTML: Breadcrumbs not recognizing HTML5 optional tags #184129

920hime opened this issue Jun 2, 2023 · 9 comments
Assignees
@aeschli

Comments

@920hime
Copy link

920hime commented Jun 2, 2023 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

  1. OK.

    • foo
    • bar ( → **ul > li**)

  2. NG.

    • foo
    • bar ( → **ul > li > li**)
  • VS Code Version: 1.78.2
  • OS Version: Windows_NT x64 10.0.19045
@920hime
Copy link
Author

920hime commented Jun 2, 2023 •
edited
Loading

  1. OK.
    <ul>
    <li>foo</li>
    <li>bar (→ ul > li)</li>
    </ul>

  2. NG.
    <ul>
    <li>foo
    <li>bar (→ ul > li > li)
    </ul>

@jrieken
Copy link
Member

jrieken commented Jun 2, 2023

/needsMoreInfo

This issue lacks

  • complete copy-paste friendly source code samples

@vscodenpa vscodenpa added the ~info-needed Issue requires more information from poster (with bot comment) label Jun 2, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.

Happy Coding!

@vscodenpa vscodenpa added info-needed Issue requires more information from poster and removed ~info-needed Issue requires more information from poster (with bot comment) labels Jun 2, 2023
@920hime
Copy link
Author

920hime commented Jun 2, 2023 •
edited by aeschli
Loading 

<!DOCTYPE html>
<html lang="en">

<head>
    <title>issue #184129</title>
    <meta charset="UTF-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
</head>

<body>

HTML: パンくずリストが HTML5 の省略可能タグを認識していない<br>
HTML: Breadcrumbs not recognizing HTML5 optional tags<br>

  1. OK.

    • foo
    • bar (→ ul > li)

  2. NG.

    • foo
    • bar (→ ul > li > li)

@jrieken
Copy link
Member

jrieken commented Jun 2, 2023

This doesn't look like valid html. Are sure you mean breadcrumbs or is this about emmet tag completions?

@920hime
Copy link
Author

920hime commented Jun 2, 2023 •
edited
Loading

This is because the breadcrumb doesn't know the existence of the optional closing tag.

Ref. 'Tag omission' → https://developer.mozilla.org/en-US/docs/Web/HTML/Element/li
Ref. Others include → p, dt, dd, li, option, thead, tfoot, th, tr, td, rt, rp, optgroup, caption

@jrieken
Copy link
Member

jrieken commented Jun 2, 2023

Please provide a complete, copy paste friendly code sample so that we can reproduce this issue

@920hime
Copy link
Author

920hime commented Jun 3, 2023

<!DOCTYPE html>
<html lang="en">

<head>
<title>issue #184129</title>
<meta charset="UTF-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
</head>

<body>
HTML: パンくずリストが HTML5 の省略可能タグを認識していない<br>
HTML: Breadcrumbs not recognizing HTML5 optional tags<br>

  1. OK.
    <ul>
    <li>foo</li>
    <li>bar (click here → ul > li)</li>
    </ul>

  2. NG.
    <ul>
    <li>foo
    <li>bar (click here → ul > li > li)
    </ul>

</body>

</html> <--! I will email you the original --->

@jrieken jrieken assigned aeschli and unassigned jrieken Jun 5, 2023
@jrieken jrieken removed the info-needed Issue requires more information from poster label Jun 5, 2023
@aeschli
Copy link
Contributor

aeschli commented Aug 21, 2023

Duplicate of microsoft/vscode-html-languageservice#63

@aeschli aeschli closed this as completed Aug 21, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jrieken @aeschli @vscodenpa @920hime