Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions with auto update flow uninstalled after reload #199309

Closed
deepak1556 opened this issue Nov 28, 2023 · 3 comments
Closed

Extensions with auto update flow uninstalled after reload #199309

deepak1556 opened this issue Nov 28, 2023 · 3 comments
Assignees

Comments

@deepak1556
Copy link
Collaborator

Testing #199180

  • Set update flow to OnlySelectedExtensions
  • Have multiple extensions from same publisher installed, in my case installed Docker, ESLint and DevContainers
  • Set Auto Update for Docker and ESLint
  • Downgrade the extension versions as mentioned in Test selective auto updating of extensions #199180 (comment)
  • See the update banner popup on the selected extensions
  • Extensions were auto updated but the banner still persists
  • Package.json of the extensions still refers to the old version although the extension UI reports differently
  • Now update the Package.json value to the current installed version
  • See reload required banner pop up
  • Click the reload action and extension gets removed
Screen.Recording.2023-11-28.at.20.19.09.mp4
@sandy081
Copy link
Member

I have to say manually messing up the version in package.json and extensions.json file can cause unexpected behaviour like this. Sorry that I recommended this workaround to see updates.

This seems to be suspicious. VS Code has clean up mechanism to remove outdated versions. Because of manual edits, clean up mechanism would have kicked off and uninstalled the extension.

If this approach helped you to test auto update feature then this should be sufficient. Side affects like this are due to the manual edits.

@deepak1556
Copy link
Collaborator Author

Makes sense. Curious, when you were developing this feature how did you test it ? Was it using published extensions that you control ?

@sandy081
Copy link
Member

I was also updating above files I mentioned but differently.

  • Used Install Another Version action from the UI
  • Removed the pinned attribute from the extensions.json file

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants