Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird buggy behavior with the checkbox #199419

Closed
TylerLeonhardt opened this issue Nov 28, 2023 · 11 comments
Closed

Weird buggy behavior with the checkbox #199419

TylerLeonhardt opened this issue Nov 28, 2023 · 11 comments
Assignees
Labels
extensions Issues concerning extensions *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach

Comments

@TylerLeonhardt
Copy link
Member

Testing #199180

Something isn't working right with this feature... I'm not seeing Auto Update get checked.
https://github.com/microsoft/vscode/assets/2644648/4285373a-1ed5-4081-8193-625e0d0a001a

In this case I toggle auto update all and then I see both checked (maybe expected?) and then I uncheck auto update for a single extension and it updates it in both?
https://github.com/microsoft/vscode/assets/2644648/0cb36349-f91c-465b-bf33-6639158cf8ee

I was basically going back and forth between the two Copilot extensions checking either Auto Update All and Auto Update and was seeing these.

Also, what does a CHECKED Auto Update All and an UNCHECKED Auto Update mean? What does a CHECKED Auto Update All and a CHECKED Auto Update mean?

@sandy081
Copy link
Member

sandy081 commented Nov 28, 2023

what does a CHECKED Auto Update All and an UNCHECKED Auto Update mean?

It means you want all extensions published by that publisher to be auto updated except this extension.

What does a CHECKED Auto Update All and a CHECKED Auto Update mean?

It means, this extension and all extensions published by that publishers are auto updated

@sandy081 sandy081 added this to the November 2023 milestone Nov 28, 2023
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Nov 28, 2023
@sandy081
Copy link
Member

@TylerLeonhardt I am not able to reproduce the issue. Are there any specific steps you are following?

@sandy081 sandy081 removed this from the November 2023 milestone Nov 29, 2023
@sandy081 sandy081 added info-needed Issue requires more information from poster and removed bug Issue identified by VS Code Team member as probable bug labels Nov 29, 2023
@TylerLeonhardt
Copy link
Member Author

I don't know... I think I'm in a broken state because if I do:

  • Empty workspace
  • Settings Sync off
  • All Extrensions
  • None
  • Selected Extensions

I see that these extensions already have values:

Image

Image

@TylerLeonhardt
Copy link
Member Author

Ok clicking Auto Update All seems to put me back in a good state... alright I think the confusion I have is that... once you choose "Auto Update" on an extension once, that extension no longer can be controlled by "Auto Update All".

Steps:

  • Check Auto Update All in Copilot
  • Uncheck Auto Update in Copilot
  • Uncheck Auto Update All in Copilot Chat
  • verify Copilot is still unchecked in both Auto Update and Auto Update All
  • Check Auto Update All in Copilot Chat
  • Notice that Copilot is Auto Update All but not Auto Update

@sandy081
Copy link
Member

This is because you previous choose Uncheck Auto Update in Copilot - disable auto updates for Copilot which is remembered even after toggling Auto Update All. Do you expect when doing Check Auto Update All resets your decision on Copilot extension?

@TylerLeonhardt
Copy link
Member Author

Yeah I think that's where I am leaning. The reason I say that is because when I first saw this scenario of checkmarks:

Image

I thought "oh this extension will be updated because I have Auto Update All checked". I didn't really think that this meant "oh this extension won't be updated because I explicitly opted out for this extension already".

Yeah idk, I'd like to hear what other folks think. I might be just over thinking this

@sandy081
Copy link
Member

sandy081 commented Dec 1, 2023

I see. Does it help if I rename the action to Auto Update This Extension ?

@TylerLeonhardt
Copy link
Member Author

That helps a bit. Honestly, what I would prefer is that the label changes... so like first you see:

  • Auto Update This Extension
  • Auto Update All (From Publisher)

When you click on Auto Update All, it then changes to:

  • Ignore Updates For This Extension
  • ✔️ Auto Update All (From Publisher)

or like idk something like that that makes it clear that the top one overrides the bottom one

@sandy081
Copy link
Member

sandy081 commented Dec 4, 2023

It means the label should also change when you click on Auto Update This Extension to Ignore Updates for This Extension.

So, can I assume that ✔️ is not helpful?

@sandy081 sandy081 added extensions Issues concerning extensions under-discussion Issue is under discussion for relevance, priority, approach and removed info-needed Issue requires more information from poster labels Dec 4, 2023
@TylerLeonhardt
Copy link
Member Author

TylerLeonhardt commented Dec 4, 2023

Yeah I think maybe this is the issue I'm having. The checkbox only shows the difference between 2 states but really there are 4 states here. This is just my opinion though, not sure if others have felt this.

@sandy081 sandy081 added the *out-of-scope Posted issue is not in scope of VS Code label Jan 15, 2024
@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Issues concerning extensions *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

3 participants