Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra line after REPL interactions #233712

Closed
bamurtaugh opened this issue Sep 24, 2024 · 2 comments · Fixed by #233720
Closed

Extra line after REPL interactions #233712

bamurtaugh opened this issue Sep 24, 2024 · 2 comments · Fixed by #233720
Assignees
@amunger @anthonykim1
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders interactive-window verified Verification succeeded
Milestone
November 2024

Comments

@bamurtaugh
Copy link
Member

Testing #24162

I'm on Windows 11 Insiders, VS Code Insiders version:

Version: 1.94.0-insider (user setup)
Commit: f35c382
Date: 2024-09-24T05:04:12.797Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.26120

Is it expected that there are empty new lines after I Expand Cell Input:
Image
Image

And if I Copy Cell Output:
Image
Image
@anthonykim1
Copy link
Contributor

This is good catch! I feel like this came up before but there is always one newline after the first and only line of command in IW, right? @amunger

@github-actions github-actions bot added the info-needed Issue requires more information from poster label Nov 12, 2024
@amunger
Copy link
Contributor

amunger commented Nov 12, 2024

yes, the print call always adds a newline unless you explicitly tell it not to. I think we can safely just trim the result though when copying the output.

@amunger amunger self-assigned this Nov 12, 2024
@amunger amunger removed the info-needed Issue requires more information from poster label Nov 12, 2024
@amunger amunger transferred this issue from microsoft/vscode-python Nov 12, 2024
@amunger amunger added the bug Issue identified by VS Code Team member as probable bug label Nov 12, 2024
@amunger amunger added this to the November 2024 milestone Nov 12, 2024
@amunger amunger mentioned this issue Nov 12, 2024
Merged
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 12, 2024
@anthonykim1 anthonykim1 added the verified Verification succeeded label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amunger amunger

@anthonykim1 anthonykim1

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders interactive-window verified Verification succeeded
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

trim output for copying/a11yview microsoft/vscode
3 participants
@amunger @bamurtaugh @anthonykim1