Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong starting column when toggling comments for makefile commands #234464

Open
mcandre opened this issue Nov 23, 2024 · 2 comments
Open

Wrong starting column when toggling comments for makefile commands #234464

mcandre opened this issue Nov 23, 2024 · 2 comments
Assignees

Comments

@mcandre
Copy link

mcandre commented Nov 23, 2024

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.95.2
  • OS Version: macOS Sequoia

Steps to Reproduce:

  1. Write a makefile with a default task like all: and a command like echo hello.
  2. Use VSCode hotkeys to toggle comments on and off for the command.

Expected:

Code comments for make commands begin at the very first column.

Observed:

Code comments try to indent the comment. This disrupts the visual flow of makefiles, and the syntax risks interacting poorly with parsers for various make implementations and shells.

Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.95.3. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@RedCMD
Copy link
Contributor

RedCMD commented Nov 23, 2024

all:
	echo hello

pressing ctrl+/ on line 2 results in the comment being placed after the tab rather than at the start of the line
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants