add tests for terminal suggest widget, fix some bugs

[meganrogge]

[meganrogge]

Actually wip realized something

[Tyriar]

If you move this inside suite you'll be able to access variables you declare in that block. This lets you do things like this:

let commands: string[]

setup(() => {
  commands = ['default', 'set', ...];
});

function assertCompletions() {
  // references commands
}

test(() => {
  commands = ['custom test commands'];
});

[Tyriar]

I'd only generate tests inside a function like this if they originate from some array of specifications which is sometimes useful. Pulling the test call out will make integration with IDEs better and make them easier to understand.

[meganrogge]

there will be quite a bit of duplication if I do this

[meganrogge]

also not sure what you mean about integration with other IDEs

[Tyriar]

The current way you're missing out on VS Code integration at the test level:

[Tyriar]

If you do want to keep it this way though, you should put all the test specifics into an array and create them that way:

Instead of:

createTestCase('|', availableCommands, 'neither', availableSpecs);
createTestCase('c|', availableCommands, 'neither', availableSpecs);
...

Do:

const testSpecs: [my, type, ...] = [
  ['|', availableCommands, 'neither', availableSpecs]
];
// or
const testSpecs = [
  { input: '|', expectedCompletionLabels: 'files' | 'folders' | 'both' | 'neither', resourcesRequested: 'neither', availableSpecs }
];

for (const spec of testSpecs) {
  test(testSpecs.name, () => {
    // use spec to implement the test
  });
}

This saves more of the repetitive writing. This is similar to terminal link tests:

vscode/src/vs/workbench/contrib/terminalContrib/links/test/browser/terminalLinkParsing.test.ts

Lines 163 to 172 in 6070da4

	suite('removeLinkSuffix', () => {
	for (const testLink of testLinks) {
	test('`' + testLink.link + '`', () => {
	deepStrictEqual(
	removeLinkSuffix(testLink.link),
	testLink.suffix === undefined ? testLink.link : testLink.link.replace(testLink.suffix, '')
	);
	});
	}
	});

[Tyriar]

Best to stick expected as the last arg