add some more tests, fix terminal completion bug #234696
Merged
+142
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Nov 26, 2024
Comment on lines
18
to
+21
| const testSpecs: ITestSpec[] = [ | ||
| { input: '|', expectedCompletionLabels: availableCommands }, | ||
| { input: 'c|', expectedCompletionLabels: availableCommands }, | ||
| { input: 'ls && c|', expectedCompletionLabels: availableCommands }, | ||
| { input: '|', expectedCompletionLabels: availableCommands, resourcesRequested: 'both' }, | ||
| { input: 'c|', expectedCompletionLabels: availableCommands.filter(c => c.startsWith('c')) }, | ||
| { input: 'ls && c|', expectedCompletionLabels: availableCommands.filter(c => c.startsWith('c')) }, |
There was a problem hiding this comment.
I think you'll want to isolate the tests a little more or they'll just get more complicated over time. So instead of having all tests use all completions, have most unit tests focus on specific completion specs, then a small amount that deal with merging and dealing with all of them.
There was a problem hiding this comment.
makes sense, have just been fixing bugs for now. seems like something to defer.
There was a problem hiding this comment.
This was that ITestSpec2 interface we wrote up together 👍
Tyriar
reviewed
Nov 27, 2024
Comment on lines
18
to
+21
| const testSpecs: ITestSpec[] = [ | ||
| { input: '|', expectedCompletionLabels: availableCommands }, | ||
| { input: 'c|', expectedCompletionLabels: availableCommands }, | ||
| { input: 'ls && c|', expectedCompletionLabels: availableCommands }, | ||
| { input: '|', expectedCompletionLabels: availableCommands, resourcesRequested: 'both' }, | ||
| { input: 'c|', expectedCompletionLabels: availableCommands.filter(c => c.startsWith('c')) }, | ||
| { input: 'ls && c|', expectedCompletionLabels: availableCommands.filter(c => c.startsWith('c')) }, |
Tyriar
reviewed
Nov 27, 2024
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalSuggestAddon.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the rest of the code that deals with completions into the function that we're testing, so now truly represents what's being returned.
Added tests cases for the bug and made the fixes so that they now pass.
fix #234667