Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL with os, revision and arch #47

Open
jcfr opened this issue Apr 19, 2013 · 4 comments
Open

Update URL with os, revision and arch #47

jcfr opened this issue Apr 19, 2013 · 4 comments
Assignees

Comments

@jcfr
Copy link
Contributor

jcfr commented Apr 19, 2013

After selecting parameters, the url is not updated.

@ghost ghost assigned zachmullen Apr 19, 2013
@zachmullen
Copy link
Member

Do you want this to pushState or replaceState? I.e., if the user clicks back, do they iterate through each change they made to the os/revision/arch, or do they go to the page they were on before they entered the app store index page?

@jcfr
Copy link
Contributor Author

jcfr commented Apr 19, 2013

I would like to stick to what the Midas convention would be if any. The
whole midas experience should be consistent.

That said, if not such convention have been defined yet, I think the
"pushState" makes sens. Similar to how the github issue page behave. See
https://github.com/commontk/CTK/issues?state=closed

If you change sort option, or click on "Open" or "Close" .. then click
back, it will bring you to the previous state.

Ideally, we should be implemented in Midas core so that it could benefit
the entire framework. Let me know if generalizing this it is feasible.

Thanks
Jc

On Fri, Apr 19, 2013 at 1:44 PM, Zach Mullen [email protected]:

Do you want this to pushState or replaceState? I.e., if the user clicks
back, do they iterate through each change they made to the
os/revision/arch, or do they go to the page they were on before they
entered the app store index page?


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-16668552
.

+1 919 869 8849

@zachmullen
Copy link
Member

I don't think we want to do this generally in Midas. There are a lot of client-side javascript application frameworks that build this in automatically such as Backbone.js or ember.js. Generalizing this across Midas should happen when we eventually move to a framework that has already solved the problem :)

@jcfr
Copy link
Contributor Author

jcfr commented Apr 19, 2013

Sounds good. In that case, it makes sens to implement a specific solution.
That said, it there are already code doing such things in midas .. let's
make sure to re-use it.

Thanks
Jc

On Fri, Apr 19, 2013 at 2:04 PM, Zach Mullen [email protected]:

I don't think we want to do this generally in Midas. There are a lot of
client-side javascript application frameworks that build this in
automatically such as Backbone.js or ember.js. Generalizing this across
Midas should happen when we eventually move to a framework that has already
solved the problem :)


Reply to this email directly or view it on GitHubhttps://github.com//issues/47#issuecomment-16669662
.

+1 919 869 8849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants