forked from rubocop/rubocop-rspec
-
Notifications
You must be signed in to change notification settings - Fork 0
/
describe_class.rb
45 lines (39 loc) · 1.15 KB
/
describe_class.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
# encoding: utf-8
# frozen_string_literal: true
module RuboCop
module Cop
module RSpec
# Check that the first argument to the top level describe is the tested
# class or module.
#
# @example
# # bad
# describe 'Do something' do
# end
#
# # good
# describe TestedClass do
# end
#
# describe "A feature example", type: :feature do
# end
class DescribeClass < Cop
include RuboCop::RSpec::TopLevelDescribe
REQUEST_PAIR = s(:pair, s(:sym, :type), s(:sym, :request))
FEATURE_PAIR = s(:pair, s(:sym, :type), s(:sym, :feature))
MESSAGE = 'The first argument to describe should be the class or ' \
'module being tested.'
def on_top_level_describe(_node, args)
return if args[0] && args[0].type == :const
return if args[1..-1].any? do |arg|
next unless arg.hash_type?
arg.children.any? do |n|
[REQUEST_PAIR, FEATURE_PAIR].include?(n)
end
end
add_offense(args[0], :expression, MESSAGE)
end
end
end
end
end