Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails if A-Record is not parseable as IP address #7

Open
schrer opened this issue Nov 27, 2021 · 1 comment
Open

Fails if A-Record is not parseable as IP address #7

schrer opened this issue Nov 27, 2021 · 1 comment

Comments

@schrer
Copy link

schrer commented Nov 27, 2021

If a new domain is bought and not set up in GoDaddy it has an A-Record of value "Parked".
The tool fails to parse "Parked" as IP address, fails and exits with code 1

In the scenario of the completely new domain this can be easily circumvented by e.g. manually setting some IP address as initial value in the GoDaddy web interface, but an automatic handling would be nice.
Not sure though if there are cases where the API request for the A-record could return a non-IP value and it's not something that should just be overwritten?
Could the value "Parked" be overwritten without worry or is there any value in keeping it and the program failing?

@mikemyl
Copy link
Owner

mikemyl commented Nov 28, 2021

Ah that's interesting, didn't know about that "Parked" response. I have tried registering a new subdomain (where no IP address is assigned yet), but I didn't get that "Parked" reply - I guess it's handled differently.

Have you, by any chance captured that response from GoDaddy? If not, I'll do some reading to figure it out.

I think that, we should handle the A record not being an IP address - and in that case, we should set the IP to the current, public IP address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants