You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
These are the test cases I believe need to be added: {"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/602.1 (KHTML, like Gecko) splash Version/10.0 Safari/602.1", "Splash", "10.0", "bot", ua.Linux}, {"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/538.1 (KHTML, like Gecko) splash Safari/538.1", "Splash", "", "bot", ua.Linux}, {"Scrapy/2.6.3 (+https://scrapy.org)", "Scrapy", "2.6.3", "bot", ""},
The text was updated successfully, but these errors were encountered:
First off, awesome work and find the implementation easy to extend / modify.
Wanted to reach out to mention a couple of test cases to add for some bot user agents coming from Splash and Scrapy.
Here are some Splash user agents I've seen in the wild fairly regularly:
And for scrapy:
These are the test cases I believe need to be added:
{"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/602.1 (KHTML, like Gecko) splash Version/10.0 Safari/602.1", "Splash", "10.0", "bot", ua.Linux}, {"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/538.1 (KHTML, like Gecko) splash Safari/538.1", "Splash", "", "bot", ua.Linux}, {"Scrapy/2.6.3 (+https://scrapy.org)", "Scrapy", "2.6.3", "bot", ""},
The text was updated successfully, but these errors were encountered: