Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Do not panic if a Rust function returns an error #37930

Open
1 task done
sunby opened this issue Nov 22, 2024 · 1 comment
Open
1 task done

[Enhancement]: Do not panic if a Rust function returns an error #37930

sunby opened this issue Nov 22, 2024 · 1 comment
Assignees
@sunby
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@sunby
Copy link
Contributor

sunby commented Nov 22, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Now we only call unwrap in Rust function and make system crash.
Maybe we can convert Rust error to a C++ struct and return to caller, then we can handle it in C++.

Why is this needed?

No response

Anything else?

No response
@sunby sunby added the kind/enhancement Issues or changes related to enhancement label Nov 22, 2024
@sunby
Copy link
Contributor Author

sunby commented Nov 25, 2024

/assign

@sunby sunby mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunby sunby

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunby