Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix rbac v2 grantor and error messages #38004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix rbac v2 grantor and error messages #38004

wants to merge 1 commit into from
+30 −22

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Nov 25, 2024 •
edited
Loading

issue: #37031
fix: #37974, #37903, #37843, #38002

@shaoting-huang shaoting-huang changed the title fix rbac v2 grantor and error messages fix: fix rbac v2 grantor and error messages Nov 25, 2024
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 25, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (27c22d1) to head (9faa7b3).

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 69.23% 3 Missing and 1 partial ⚠️
internal/proxy/impl.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38004       +/-   ##
===========================================
+ Coverage   68.87%   82.97%   +14.09%     
===========================================
  Files         289     1071      +782     
  Lines       25481   165301   +139820     
===========================================
+ Hits        17551   137160   +119609     
- Misses       7930    22665    +14735     
- Partials        0     5476     +5476
Components Coverage Δ
Client 72.33% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.26% <82.14%> (∅)
Files with missing lines Coverage Δ
internal/proxy/util.go 89.97% <100.00%> (ø)
internal/proxy/impl.go 84.64% <0.00%> (ø)
internal/rootcoord/root_coord.go 89.44% <69.23%> (ø)

... and 1357 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cydrain cydrain Awaiting requested review from cydrain

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: [privilege_group] The error message is wrong when input invalid "db_name" for "grant_v2" interface
2 participants
@shaoting-huang @sre-ci-robot