Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add switch for local rpc enabled #37985

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 25, 2024

issue: #33285

  • Add switch for local rpc

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.08%. Comparing base (4cd7932) to head (09a0516).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/coordinator/coordclient/registry.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37985       +/-   ##
===========================================
+ Coverage   68.87%   81.08%   +12.20%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190788   +165307     
===========================================
+ Hits        17551   154702   +137151     
- Misses       7930    30607    +22677     
- Partials        0     5479     +5479     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.26% <75.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.36% <100.00%> (ø)
internal/coordinator/coordclient/registry.go 88.46% <0.00%> (ø)

... and 1069 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the enhance_merge_all_coord_into_one branch from fb7e097 to c022cb1 Compare November 25, 2024 08:45
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 25, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@jaime0815
Copy link
Contributor

rerun go-sdk

@jaime0815
Copy link
Contributor

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants