Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the default partition for the limit quota when the request partition name is empty #38005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 25, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimFG
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
@bigsheeper
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (27c22d1) to head (b1b97c4).

Files with missing lines Patch % Lines
internal/proxy/task_insert.go 33.33% 3 Missing and 1 partial ⚠️
internal/proxy/task_upsert.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38005       +/-   ##
===========================================
+ Coverage   68.87%   81.04%   +12.17%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190787   +165306     
===========================================
+ Hits        17551   154632   +137081     
- Misses       7930    30657    +22727     
- Partials        0     5498     +5498     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.21% <57.89%> (∅)
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.47% <100.00%> (ø)
internal/proxy/rate_limit_interceptor.go 100.00% <ø> (ø)
internal/proxy/task_insert.go 73.70% <33.33%> (ø)
internal/proxy/task_upsert.go 70.69% <33.33%> (ø)

... and 1067 files with indirect coverage changes

---- 🚨 Try these New Features:

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants