Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine pular related mq interfaces #38007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented Nov 25, 2024

issue: #35917
Refines the pulsar-related mq APIs to allow the ctx to be passed down

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 25, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tinswzy
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 25, 2024
Copy link
Contributor

mergify bot commented Nov 25, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@tinswzy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (27c22d1) to head (d771f92).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38007   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files         289      289           
  Lines       25481    25481           
=======================================
  Hits        17551    17551           
  Misses       7930     7930           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.87% <ø> (ø)
Go ∅ <ø> (∅)
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants