Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the db information in the dml message #37969

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Nov 25, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.06%. Comparing base (27c22d1) to head (1719e1a).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_upsert_streaming.go 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37969       +/-   ##
===========================================
+ Coverage   68.87%   81.06%   +12.18%     
===========================================
  Files         289     1360     +1071     
  Lines       25481   190793   +165312     
===========================================
+ Hits        17551   154663   +137112     
- Misses       7930    30638    +22708     
- Partials        0     5492     +5492     
Components Coverage Δ
Client 72.33% <ø> (∅)
Core 68.87% <ø> (-0.01%) ⬇️
Go 83.23% <77.77%> (∅)
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.42% <100.00%> (ø)
internal/proxy/msg_pack.go 73.19% <100.00%> (ø)
internal/proxy/task_delete.go 92.41% <100.00%> (ø)
internal/proxy/task_delete_streaming.go 73.46% <100.00%> (ø)
internal/proxy/task_upsert_streaming.go 0.00% <0.00%> (ø)

... and 1067 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

rerun cpp-unit-test

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

/run-cpu-e2e

@SimFG
Copy link
Contributor Author

SimFG commented Nov 25, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 25, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 26, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 26, 2024
Copy link
Contributor

mergify bot commented Nov 26, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 26, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 26, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Nov 26, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 26, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 971b4f1 into milvus-io:master Nov 27, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants