Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added button to clear all tasks. #1622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GalFajon
Copy link

Added a button that clears all tasks alongisde the "New Task" button. I also adjusted the css and index.html accordingly. In addition to all that, I added a custom bang for destroying all tasks as well.

I'll be frank, I wasn't sure how to fit it in from a UI design standpoint, but it was a feature I always wanted to see.

minbutton

@PalmerAL
Copy link
Collaborator

PalmerAL commented Jun 6, 2021

Thanks!

I don't think this is the right place for the button - it blends in with the "new task" button, and is located in an area where the "new task" button used to be. As a result, I imagine a lot of people accidentally clicking on this when they mean to create a task.

How about putting the button in the upper-left corner, inside #task-overlay-navbar? For the styling, you could do something simple like the "clear history" button:
Screen Shot 2021-06-06 at 6 29 18 PM

Also, I think it'd be a good idea to add a confirmation dialog for this - when I'm working on a project, for example, I usually have a lot of tasks open for several weeks with all the resources for the project, and accidentally deleting them all would be a big issue. You can just use confirm() for this.

@GalFajon
Copy link
Author

GalFajon commented Jun 7, 2021

Very fair response. I'll get on it.

@flightmansam
Copy link
Contributor

@GalFajon, any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants