Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes when ran on multicraft server, b/c minetest.get_server_status() returns nil. #21

Closed
dennisjenkins75 opened this issue Jan 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dennisjenkins75
Copy link

Exact same root cause as minetest-mapserver/mapserver_mod#20

So if minetest.get_server_status() returns nil (which is allowed per the API docs), then the monitoring mod should not crash. Just assume that the lag is 0 or something?

ServerError: AsyncErr: environment_Step: Runtime error from mod 'monitoring' in callback environment_Step(): ...e/1hit/worlds/world/worldmods/monitoring/builtin/lag.lua:12: bad argument #1 to 'gmatch' (string expected, got nil)
stack traceback:
        [C]: in function 'gmatch'
        ...e/1hit/worlds/world/worldmods/monitoring/builtin/lag.lua:12: in function 'explode'
        ...e/1hit/worlds/world/worldmods/monitoring/builtin/lag.lua:20: in function 'get_max_lag'
        ...e/1hit/worlds/world/worldmods/monitoring/builtin/lag.lua:46: in function 'globalstep'
        ...worlds/world/worldmods/monitoring/builtin/globalstep.lua:32: in function <...worlds/world/worldmods/monitoring/builtin/globalstep.lua:24>
        /home/1hit/multicraft/bin/../builtin/game/register.lua:441: in function </home/1hit/multicraft/bin/../builtin/game/register.lua:425>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants