Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PKCE (RFC7636) Support for OAuth #1910

Closed
1 task done
mweinelt opened this issue Jun 2, 2023 · 1 comment · Fixed by #2048
Closed
1 task done

PKCE (RFC7636) Support for OAuth #1910

mweinelt opened this issue Jun 2, 2023 · 1 comment · Fixed by #2048
Labels

Comments

@mweinelt
Copy link

mweinelt commented Jun 2, 2023

Thanks for developing miniflux and providing OAuth2.0 and OIDC support.

The OAuth2.0 interfaces specified in RFC6749 is susceptible to an authorization code attack,
when the client is hosted publicly.

This is the reason RFC7636 was created, which provices PKCE, that protects against CSRF and authorization code injections.

The golang.org/x/oauth2 package seems to support PKCE, but it would need to be hooked up.

cc @pmarschik who already implemented OIDC support in #583.

@fguillot fguillot linked a pull request Sep 3, 2023 that will close this issue
2 tasks
@fguillot
Copy link
Member

fguillot commented Sep 3, 2023

PKCE has been added in PR #2048. Tested with various IDM including Kanidm.

https://miniflux.app/docs/howto.html#oauth2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants