Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences in feed modification behavior between Web UI and API #2936

Open
AiraNadih opened this issue Nov 12, 2024 · 1 comment
Open

Differences in feed modification behavior between Web UI and API #2936

AiraNadih opened this issue Nov 12, 2024 · 1 comment

Comments

@AiraNadih
Copy link
Contributor

I noticed that when modifying a feed through the web form (e.g., disabling the feed), upon form submission, both the parsing error count and error message of that feed are reset.
However, this reset process doesn't occur when modifying the feed via API.

After examining the relevant code, I found that the reset operation appears to be automatically performed during form processing:

feed.ParsingErrorCount = 0
feed.ParsingErrorMsg = ""

This operation is not present in the API modification flow.

I'd like to know if this difference in behavior is intentional or an oversight.

If it's not intentional, perhaps we could synchronize this logic by adding originalFeed.ResetErrorCounter() to the API handling code.

@fguillot
Copy link
Member

It's probably an oversight. The same behavior could be added to the API endpoint for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants