Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon downloaded from feed URL instead of site URL #2955

Open
gabe565 opened this issue Nov 22, 2024 · 0 comments · May be fixed by #2957
Open

Icon downloaded from feed URL instead of site URL #2955

gabe565 opened this issue Nov 22, 2024 · 0 comments · May be fixed by #2957

Comments

@gabe565
Copy link
Contributor

gabe565 commented Nov 22, 2024

Hey!

I recently force refreshed some feeds and noticed that the feed icon is now downloaded based on the feed URL instead of the website URL. This was introduced by #2871 because the NewIconChecker now uses c.feed.FeedURL instead of c.feed.SiteURL:

iconFinder := NewIconFinder(requestBuilder, c.feed.FeedURL, c.feed.IconURL)

This is fine in most cases, but for any feeds that use an RSS generation service like RSS-Bridge, RSSHub, or one I built called Transsmute, the feed generator's icon will be downloaded instead of the actual website icon.

I wouldn't mind opening a PR to fix this, but I wasn't sure if the change was intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

1 participant