-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BucketExistsAsync returns true even if it does not exist #1118
Comments
This is not the only method that has wrong exception handling. I just lost few hours trying to figure out why In my case i had wrong endpoint, but NO info about this in logs or any exception...which was harder to find out because i was testing on Gitlab CI....so had only logs available I looked up your code, and the implementation of |
Yes @albracko I also experienced this with putting and getting objects, I spent a while trying to figure out why I get |
I think exception handling needs a review. my code: bool exists = await minioClient.BucketExistsAsync(new BucketExistsArgs().WithBucket(bucketName)); I will get true even if the minio container be down and not be accessible by any mean 🙄 |
Any progress on this? |
Swallowing all the errors is really disappointing. I spent a whole day investigating why the Minio dotnet Client was saying it could find a bucket I couldn't see it. Thankfully I found this github issue. To find the actual issue I ended up installing the AWSSDK.S3 nuget package and using the code below. This immediately surfaced an SSL issue. Hope you guys can get this fixed. `using Amazon; public class TestMinioAWS
} |
The logic for BucketExistsAsync is incorrect. All it determines is that the response Exception isn't a BucketNotFoundException. This means if you have another exception such as HttpRequestException, it responds that the bucket exists true even when it might not.
minio-dotnet/Minio/ApiEndpoints/BucketOperations.cs
Lines 83 to 85 in 2e46392
I was getting a "The SSL connection could not be established, see inner exception." and never knew until I stepped into the lib code.
The text was updated successfully, but these errors were encountered: